Repository navigation
URL decode headers from environment variables in OtlpConfig - #4595
Merged
shakuzen merged 3 commits intoJan 31, 2024
Merged
Conversation
marcingrzejszczak
approved these changes
Jan 24, 2024
shakuzen
changed the title
shakuzen
approved these changes
Jan 25, 2024
shakuzen
left a comment
shakuzen
left a comment
Member
There was a problem hiding this comment.
It sounds like it's a bug we didn't do this before. If so, we should include it in maintenance releases. What do you think?
Contributor
Author
I agree - see open-telemetry/opentelemetry-specification#3832 (comment) |
shakuzen
force-pushed
the
otlp-header-encoding
branch
from
January 31, 2024 04:07
abb1bf3 to
59f80bb
Compare
Member
|
Thanks. I've rebased the pull request on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for open-telemetry/opentelemetry-java#6164
Blocked by open-telemetry/opentelemetry-specification#3832