Repository navigation
Flag to register JCache cache.removals as FunctionCounter - #6471
Merged
jonatan-ivanov merged 1 commit intoJun 26, 2025
Merged
Conversation
Some other CacheMeterBinder implementations are known to register the `cache.removals` meter as a FunctionCounter, which is more semantically accurate. For backward compatibility, we do not want to unconditionally change the meter type for everyone, especially in a maintenance release. However, we want to make it possible to register the `cache.removals` as a `FunctionCounter` to align it. In the future, we can flip the default for this flag. See micrometer-metricsgh-6434
jonatan-ivanov
approved these changes
Jun 26, 2025
shakuzen
added a commit
that referenced
this pull request
Jun 27, 2025
This switches the default of the `registerCacheRemovalsAsFunctionCounter` flag from `false` to `true`. This may be a breaking change depending on the backend used and the usage of this metric in queries. This change makes the behavior what we want by default while still allowing users to fall back to the previous behavior by setting the flag to `false` to maintain compatibility with the behavior in prior versions. See gh-6471 Resolves gh-2754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some other CacheMeterBinder implementations are known to register the
cache.removalsmeter as a FunctionCounter, which is more semantically accurate. For backward compatibility, we do not want to unconditionally change the meter type for everyone, especially in a maintenance release. However, we want to make it possible to register thecache.removalsas aFunctionCounterto align it. In the future, we can flip the default for this flag.See gh-6434