Repository navigation
Use per-thread scope stack in ObservationValidator LIFO validation - #7295
Merged
Merged
Conversation
Closes micrometer-metricsgh-7288 Signed-off-by: seonghyeoklee <dltjdgur327@gmail.com>
jonatan-ivanov
approved these changes
Mar 24, 2026
Member
|
Thank you! |
jonatan-ivanov
added a commit
to jonatan-ivanov/micrometer
that referenced
this pull request
Mar 25, 2026
In micrometer-metricsgh-7295 a ThreadLocal was introduced and elements are only added to it, never removed. Also, it was reported in micrometer-metricsgh-6713 that in some cases reusing TestObservationRegistry can trigger validation issues since the validator remembers all the low cardinality key-values that were recorded previously. Both of the issues can be worked around by creating a new TestObservationRegistry instance, however in some cases clearing its memory might be more convenient. See micrometer-metricsgh-7295 See micrometer-metricsgh-6713
Member
|
Fyi: I created #7295 to be able to clear the state of the validator. |
jonatan-ivanov
added a commit
that referenced
this pull request
Mar 25, 2026
In gh-7295 a ThreadLocal was introduced and elements are only added to it, never removed. Also, it was reported in gh-6713 that in some cases reusing TestObservationRegistry can trigger validation issues since the validator remembers all the low cardinality key-values that were recorded previously. Both of the issues can be worked around by creating a new TestObservationRegistry instance, however in some cases clearing its memory might be more convenient. See gh-7295 See gh-6713
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The LIFO scope ordering validation in
ObservationValidatorused a single globalDeque<Context>, which produced false positives when observations ran in parallel on different threads (sibling scopes).This replaces the global stack with a
ThreadLocal<Deque<Context>>so that each thread tracks its own scope ordering independently.Changes
ObservationValidator:Deque<Context>βThreadLocal<Deque<Context>>withThreadLocal.withInitial(ArrayDeque::new)ObservationValidatorTests: AddsiblingScopesOnDifferentThreadsShouldBeValidtest that verifies parallel observations on separate threads no longer trigger false positivesCloses gh-7288