Skip to content

Add handler that makes the tracing data available for metrics #68

Closed

Description

@jonatan-ivanov

Right now if we want to get tracing data (i.e.: traceId/spanId) from a Tracer in a method that is triggered by the MeterObservationHandler::onStop, we are not able to get it.

This is because we close the scope of an Observation before we would call stop, here's the "call stack" with a tracing and a metrics handler:

tracing start // start span
metrics start // start timer
metrics close // noop
tracing close // removes the current span
metrics stop  // stop timer, also looks up the current span but it was removed
tracing stop  // stop span

Activity

  1. added this to the 1.0.0-RC1 milestone on Sep 15, 2022
  2. added 2 commits that reference this issue on Sep 15, 2022
    c01d789
    81fd74e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions