Repository navigation
bugfix: BaggageTextMapPropagator does not mix with current context 1163 - #1174
Merged
shakuzen merged 2 commits intoSep 19, 2025
Conversation
tomaerden-everesst
force-pushed
the
bugfix/baggage-textmap-propagation
branch
from
September 15, 2025 14:48
5ff838f to
e1acdec
Compare
Contributor
Author
|
build contains a test error, although this is not reflected in the build status (main is also flaky) |
tomaerden-everesst
force-pushed
the
bugfix/baggage-textmap-propagation
branch
from
September 15, 2025 15:10
e1acdec to
46406d1
Compare
Member
That looks to fix the recently reported issue #1172 |
shakuzen
approved these changes
Sep 16, 2025
shakuzen
left a comment
Member
There was a problem hiding this comment.
Thank you for the pull request. It looks good to me. I left one minor question, and I can polish things when merging. I manually re-ran the build to deal with the flaky test.
tomaerden-everesst
force-pushed
the
bugfix/baggage-textmap-propagation
branch
from
September 19, 2025 11:18
bd7c49c to
07b5c88
Compare
…icrometer-metrics#1163) BaggageTextMapPropagator prefers carrier values Signed-off-by: Tom Aerden <tom.aerden@cegeka.com>
…icrometer-metrics#1163) BaggageTextMapPropagator prefers carrier values Signed-off-by: Tom Aerden <tom.aerden@cegeka.com>
shakuzen
force-pushed
the
bugfix/baggage-textmap-propagation
branch
from
September 19, 2025 11:46
07b5c88 to
d9cbfe1
Compare
shakuzen
approved these changes
Sep 19, 2025
shakuzen
left a comment
Member
There was a problem hiding this comment.
Thanks for the pull request. I've rebased on 1.4.x and we'll merge forward from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also: BaggageTextMapPropagator prefers carrier values