Skip to content

Making Context-Propagation library a mandatory dependency - #37

Merged
marcingrzejszczak merged 1 commit into
mainfrom
contextPropagationMandatory
Jul 18, 2022
Merged

marcingrzejszczak merged 1 commit into
mainfrom
contextPropagationMandatory

Conversation

@marcingrzejszczak

Copy link
Copy Markdown
Contributor

Without this being mandatory things like ObservationThreadLocalAccessor from Micrometer Core will not be applicable

In general without Context Propagation Tracing will not work properly

@marcingrzejszczak marcingrzejszczak added the enhancement New feature or request label Jul 15, 2022
@marcingrzejszczak marcingrzejszczak added this to the 1.0.0-M7 milestone Jul 15, 2022
Without this being mandatory things like ObservationThreadLocalAccessor from Micrometer Core will not be applicable

In general without Context Propagation Tracing will not work properly
@marcingrzejszczak
marcingrzejszczak force-pushed the contextPropagationMandatory branch from dac1c30 to e926eec Compare July 18, 2022 07:59
@marcingrzejszczak
marcingrzejszczak merged commit 792f336 into main Jul 18, 2022
@marcingrzejszczak
marcingrzejszczak deleted the contextPropagationMandatory branch July 18, 2022 12:22

dependencies {
api 'io.micrometer:micrometer-observation'
api 'io.micrometer:context-propagation'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it needed as api or implementation? In other words, do users of micrometer tracing need context-propagation on the classpath when compiling or only at runtime? If context-propagation types are not in any of tracing's API that users would compile against, then it can be implementation instead, I think.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll change it to implementation then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants