Repository navigation
Trim out more legacy projections fallback paths - #1443
Merged
Sergio Pedri (Sergio0694) merged 3 commits intoJan 26, 2024
Merged
Conversation
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
January 13, 2024 19:39
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/trim-fallback-paths
branch
2 times, most recently
from
January 14, 2024 13:28
dad262c to
821c6d6
Compare
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/trim-fallback-paths
branch
from
January 14, 2024 14:17
821c6d6 to
678603c
Compare
Manodasan Wignarajah (manodasanW)
approved these changes
Jan 17, 2024
Manodasan Wignarajah (manodasanW)
self-requested a review
January 17, 2024 08:07
Member
|
Looks like there are new authoring test failures: [ FAILED ] AuthoringTest.Arrays |
Manodasan Wignarajah (manodasanW)
approved these changes
Jan 25, 2024
Member
Author
|
All green, and only 1 failing authoring test now, which was already failing before too:
|
Sergio Pedri (Sergio0694)
deleted the
user/sergiopedri/trim-fallback-paths
branch
January 26, 2024 03:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just allows completely trimming out some fallback paths for legacy projections. These should never be reached when using NativeAOT, and even if they were, old projections are not supported in AOT scenarios anyway, so no point in keeping this.