Repository navigation
Remove [Serializable] support from exceptions - #1453
Merged
Sergio Pedri (Sergio0694) merged 3 commits intoFeb 23, 2024
Merged
Sergio Pedri (Sergio0694) merged 3 commits into
Sergio Pedri (Sergio0694) merged 3 commits into
Conversation
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
January 18, 2024 11:20
Sergio Pedri (Sergio0694)
changed the title
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/remove-exception-serializable
branch
from
January 18, 2024 20:31
2dcfd26 to
04774d5
Compare
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/remove-exception-serializable
branch
from
February 5, 2024 20:40
04774d5 to
06b8342
Compare
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/remove-exception-serializable
branch
from
February 23, 2024 05:35
06b8342 to
af183f3
Compare
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
February 23, 2024 05:42
Manodasan Wignarajah (manodasanW)
approved these changes
Feb 23, 2024
Sergio Pedri (Sergio0694)
deleted the
user/sergiopedri/remove-exception-serializable
branch
February 23, 2024 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all
[Serializable]support from exception types, as it's obsolete and shouldn't be used.It also seals all exception types while at it. No consumer should be extending these anyway.