Repository navigation
Suppress useless IL2080 warnings in fallback paths - #1515
Merged
Sergio Pedri (Sergio0694) merged 3 commits intoMar 13, 2024
Merged
Sergio Pedri (Sergio0694) merged 3 commits into
Sergio Pedri (Sergio0694) merged 3 commits into
Conversation
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/guard-mgt-calls
branch
from
February 29, 2024 18:35
b473692 to
6b5e475
Compare
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/guard-mgt-calls
branch
2 times, most recently
from
March 12, 2024 21:32
05d472f to
306fb63
Compare
Base automatically changed from
user/sergiopedri/guard-mgt-calls
to
staging/AOT
March 13, 2024 00:28
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/suppress-invalid-il2080
branch
from
March 13, 2024 01:51
0910606 to
a03c11a
Compare
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
March 13, 2024 07:24
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/suppress-invalid-il2080
branch
from
March 13, 2024 18:25
e5d32d9 to
a03c11a
Compare
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
March 13, 2024 18:29
Manodasan Wignarajah (manodasanW)
approved these changes
Mar 13, 2024
Sergio Pedri (Sergio0694)
deleted the
user/sergiopedri/suppress-invalid-il2080
branch
March 13, 2024 21:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suppresses a bunch of IL2080 warnings for
MakeGenericCallsthat we know are actually safe. The warnings come from the fact the ABI type arguments are passed to type parameters using theunmanagedconstraint, which impliesstruct, which impliesnew(), which in turn implies[DynamicallyAccessedMemebrs(PublicParameterlessConstructor)]. Because we know that all our ABI types are just blittable and will never have a constructor, we can just safely suppress these warnings.Note
I recommend reviewing this with whitespace hidden.