Skip to content

Add DataTransferManger interop APIs - #1528

Merged
Manodasan Wignarajah (manodasanW) merged 9 commits into
microsoft:staging/AOTfrom
Gaoyifei1011:master
Mar 14, 2024
Merged

Add DataTransferManger interop APIs#1528
Manodasan Wignarajah (manodasanW) merged 9 commits into
microsoft:staging/AOTfrom
Gaoyifei1011:master

Conversation

@Gaoyifei1011

@Gaoyifei1011 高怡飞 (Gaoyifei1011) commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Add DataTransferManger interop APIs

Sergio0694
Sergio Pedri (Sergio0694) requested changes Mar 7, 2024
View reviewed changes
Comment thread src/cswinrt/strings/ComInteropHelpers.cs Resolved
Comment thread src/cswinrt/strings/ComInteropHelpers.cs Resolved
Comment thread src/cswinrt/strings/ComInteropHelpers.cs Resolved
Comment thread src/cswinrt/strings/ComInteropHelpers.cs Resolved
Comment thread src/cswinrt/strings/ComInteropHelpers.cs
#else
public
#endif
static class DataTransferManagerInterop

@Sergio0694 Sergio Pedri (Sergio0694) Mar 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to add XML docs.

@manodasanW

Manodasan Wignarajah (manodasanW) commented Mar 8, 2024

Copy link
Copy Markdown
Member

I think for now as long as this new class is similar for the most part to the other interop classes, it is good. These look to be the docs for this interface. I will be retargeting this PR to the staging branch given this is an API surface change and that is our next planned assembly version change.

@manodasanW
Manodasan Wignarajah (manodasanW) changed the base branch from master to staging/AOT March 8, 2024 03:13
@manodasanW

Manodasan Wignarajah (manodasanW) commented Mar 8, 2024

Copy link
Copy Markdown
Member

Ran CI build.

@Marv51

Marvin Rühe (Marv51) commented Mar 8, 2024

Copy link
Copy Markdown

Hey this sounds amazing! I would be so happy for this to be properly supported.
I looked at the class and it looks like this would fix my issues:
#970, microsoft/microsoft-ui-xaml#4886, microsoft/CsWin32#246 and microsoft/win32metadata#867
(I really tried to make this happen in 2021...)

@Gaoyifei1011
Use IIDataTransferManagerInteropMethods to implement DataTransferMana…
e4877cb 
…gerInterop

Use IIDataTransferManagerInteropMethods to implement DataTransferManagerInterop.
Because IDataTransferManagerInterop COM interfaces are not inherited from IInspectable, but IUnknown
@Gaoyifei1011 @manodasanW
Update src/cswinrt/strings/ComInteropHelpers.cs
9c22da1 
Co-authored-by: Manodasan Wignarajah <manodasan@hotmail.com>
@Gaoyifei1011 @manodasanW
Update src/cswinrt/strings/ComInteropHelpers.cs
a6d1043 
Co-authored-by: Manodasan Wignarajah <manodasan@hotmail.com>
@Gaoyifei1011
Update src/cswinrt/strings/ComInteropHelpers.cs
750f43e 
Update src/cswinrt/strings/ComInteropHelpers.cs
dongle-the-gadget
Dongle (dongle-the-gadget) reviewed Mar 13, 2024
View reviewed changes
Comment thread src/cswinrt/strings/ComInteropHelpers.cs Outdated
static class DataTransferManagerInterop
{
private static readonly global::System.Guid IDataTransferManagerInterop_IID = new global::System.Guid("3A3DCD6C-3EAB-43DC-BCDE-45671CE800C8");
private static readonly global::System.Guid IDataTransferManagerInterop_IID = new global::System.Guid(0x3A3DCD6C, 0x3EAB, 0x43DC, 0xBC, 0xDE, 0x45, 0x67, 0x1C, 0xE8, 0x00, 0xC8);

@dongle-the-gadget Dongle (dongle-the-gadget) Mar 13, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong endianess.

@manodasanW Manodasan Wignarajah (manodasanW) Mar 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I am wrong, but this uses the format where the values goes as parameters and not in the byte array where we need to flip it for endianness, so I think this is correct right?

https://learn.microsoft.com/en-us/dotnet/api/system.guid.-ctor?view=net-8.0#system-guid-ctor(system-int32-system-int16-system-int16-system-byte-system-byte-system-byte-system-byte-system-byte-system-byte-system-byte-system-byte)

@manodasanW

Manodasan Wignarajah (manodasanW) commented Mar 13, 2024

Copy link
Copy Markdown
Member

I think once the last set of feedback is addressed, we should be good with this change.

@manodasanW

Manodasan Wignarajah (manodasanW) commented Mar 14, 2024

Copy link
Copy Markdown
Member

Thanks for this change, will merge once CI is done.

@manodasanW

Manodasan Wignarajah (manodasanW) commented Mar 14, 2024

Copy link
Copy Markdown
Member

CI finished and all tests passed.

@manodasanW
Manodasan Wignarajah (manodasanW) merged commit 4060a0f into microsoft:staging/AOT Mar 14, 2024
@manodasanW Manodasan Wignarajah (manodasanW) linked an issue Mar 19, 2024 that may be closed by this pull request
Please simply wrap the DataTransferManager interop class #1344
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Aug 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sergio0694 Sergio Pedri (Sergio0694) Sergio0694 requested changes
@manodasanW Manodasan Wignarajah (manodasanW) manodasanW approved these changes
+1 more reviewer
@dongle-the-gadget Dongle (dongle-the-gadget) dongle-the-gadget left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please simply wrap the DataTransferManager interop class

5 participants

@Gaoyifei1011 @manodasanW @Marv51 @Sergio0694 @dongle-the-gadget