Repository navigation
Fix remaining scenarios still calling FindVftblType - #1545
Merged
Manodasan Wignarajah (manodasanW) merged 1 commit intoMar 22, 2024
Merged
Conversation
…aces such as IAsyncOperation are implemented by RCWs.
Sergio Pedri (Sergio0694)
approved these changes
Mar 21, 2024
Sergio Pedri (Sergio0694)
left a comment
Sergio Pedri (Sergio0694)
left a comment
Member
There was a problem hiding this comment.
LGTM! Approving it now since we didn't have a test for this anyway, feel free to either just push a commit adding one to this PR, or make a separate PR later just adding that test. Either way, the change itself is clearly a good one 😄
Manodasan Wignarajah (manodasanW)
deleted the
manodasanw/removeFindVftbl
branch
March 22, 2024 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RCWs implementing IAsyncOperation<> happened to be calling FindVftblType. This removes the remaining scenario still calling it.