Repository navigation
Add WinRTRuntimeClassName attribute for use in scenarios where we previously used interface name - #1573
Merged
Manodasan Wignarajah (manodasanW) merged 10 commits intoApr 19, 2024
Conversation
…opriate scenarios.
Manodasan Wignarajah (manodasanW)
requested a review
from Sergio Pedri (Sergio0694)
April 17, 2024 15:15
This was referenced Apr 17, 2024
Sergio Pedri (Sergio0694)
approved these changes
Apr 19, 2024
Manodasan Wignarajah (manodasanW)
deleted the
manodasanw/generated-runtime-class-name
branch
April 19, 2024 05:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In scenarios where we have a type that isn't a WinRT type, but implements WinRT interfaces, we previously went through the interfaces and determined the most derived one to return as the runtime class name. This is not trim friendly. With these changes, we will do this in the AOT source generator rather than at runtime and instead at runtime lookup the attribute on the type. This also allows the opportunity for someone in this scenario to specify their own class name if desired as today if there are multiple interfaces that don't inherit from each other, we will need to choose one and that might not be what is desired by the author.
In addition to the scenarios where we put the attribute on the type, there are a couple scenarios where the type isn't authored in the component but rather a system type. To handle these scenarios, we use the lookup table similar to what we do in the CCW vtable scenario.