Repository navigation
Add 'CsWinRTEnableIDynamicInterfaceCastableSupport' feature switch - #1583
Merged
Sergio Pedri (Sergio0694) merged 4 commits intoApr 24, 2024
Merged
Sergio Pedri (Sergio0694) merged 4 commits into
Sergio Pedri (Sergio0694) merged 4 commits into
Conversation
Contributor
|
This would break |
Member
Author
|
Only if it gets to the fallback IDIC cast from |
Member
|
Note that this is just a feature switch for size improvements if you do not need the IDIC functionality. If you do need it, you would have the feature switch on which is also the default. |
Contributor
The only case it won't fallback IDIC is if the interface is using built-in COM Interop, which already doesn't support NativeAOT anyway. |
Member
Author
|
Saves 52 KB in the minimal sample, plus more incremental savings as you have more enumerable types 🚀
|
Sergio Pedri (Sergio0694)
marked this pull request as ready for review
April 23, 2024 17:51
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/idic-feature-switch2
branch
from
April 23, 2024 21:59
d3ffb5c to
6e7ec4b
Compare
Manodasan Wignarajah (manodasanW)
approved these changes
Apr 24, 2024
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/idic-feature-switch2
branch
from
April 24, 2024 01:07
6e7ec4b to
61f22e0
Compare
Sergio Pedri (Sergio0694)
deleted the
user/sergiopedri/idic-feature-switch2
branch
April 24, 2024 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the 'CsWinRTEnableIDynamicInterfaceCastableSupport' feature switch to allow trimming of all IDIC-related code. This would also include fixing the size regression introduced by #1566 (which can't be fixed without making the code non trim-safe).
Note
Opening as draft until I get a sizoscope diff.