Repository navigation
Fix marshaling in AOT source generator - #1628
Merged
Manodasan Wignarajah (manodasanW) merged 5 commits intoJun 2, 2024
Merged
Manodasan Wignarajah (manodasanW) merged 5 commits into
Manodasan Wignarajah (manodasanW) merged 5 commits into
Conversation
Manodasan Wignarajah (manodasanW)
commented
May 31, 2024
Manodasan Wignarajah (manodasanW)
commented
Member
- When we were marshaling bool, we were previously trying to cast to a byte from bool or vice versa. This results in a compiler error. Addressing it by replacing it with a check for != 0 or check for true / false.
- Array marshaling was also broken for bool, fixing it by making it use MarshalNonBlittable rather than trying to find the ABI type for bool.
Scott Jones (Scottj1s)
approved these changes
May 31, 2024
Sergio Pedri (Sergio0694)
approved these changes
Jun 1, 2024
…hub.com/microsoft/CsWinRT into manodasanw/fixsourcegeneratormarshaling
Manodasan Wignarajah (manodasanW)
deleted the
manodasanw/fixsourcegeneratormarshaling
branch
June 2, 2024 16:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
