Repository navigation
Make generator compatible with older version of projections - #1710
Merged
Manodasan Wignarajah (manodasanW) merged 2 commits intoAug 7, 2024
Merged
Conversation
Sergio Pedri (Sergio0694)
approved these changes
Aug 7, 2024
Manodasan Wignarajah (manodasanW)
deleted the
manodasanw/fixgeneratorbackcompat
branch
August 7, 2024 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the AOT generator is used in apps that have references to older CsWinRT projections, it shouldn't result in compiler errors. Instead, we should produce warnings that indicate so. Also, special casing 3 types in the
RcwReflectionFallbackGeneratoras those types moved projections and due to that it can run into reference issues when used with older version of projections.