Repository navigation
Minor improvements to 'ExceptionHelpers.SetErrorInfo' - #1824
Merged
Manodasan Wignarajah (manodasanW) merged 3 commits intoOct 22, 2024
Merged
Conversation
Sergio Pedri (Sergio0694)
added
performance
Sergio Pedri (Sergio0694)
requested a review
from Manodasan Wignarajah (manodasanW)
October 14, 2024 05:52
Sergio Pedri (Sergio0694)
force-pushed
the
user/sergiopedri/exception-tweaks
branch
from
October 14, 2024 05:52
bd0b721 to
0327e44
Compare
Manodasan Wignarajah (manodasanW)
approved these changes
Oct 22, 2024
Manodasan Wignarajah (manodasanW)
deleted the
user/sergiopedri/exception-tweaks
branch
October 22, 2024 03:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes just a couple of tweaks to
ExceptionHelpers.SetErrorInfo:WindowsCreateStringReference, since we can just pin the source text.IObjectReferenceobject.