Skip to content

<xhash>: Use ceiling instead of rounding when calculating number of buckets - #3687

Merged
Casey Carter (CaseyCarter) merged 1 commit into
microsoft:mainfrom
MattStephanson:gh732-hash-reserve
May 18, 2023
Merged

Casey Carter (CaseyCarter) merged 1 commit into
microsoft:mainfrom
MattStephanson:gh732-hash-reserve

Conversation

@MattStephanson

Copy link
Copy Markdown
Contributor

Fixes #732.

@StephanTLavavej

Copy link
Copy Markdown
Member

Looks great, thank you! I convinced myself that there are no ABI implications because this only alters the behavior of reserve() and the actual number of buckets is always a power of 2.

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@CaseyCarter Casey Carter (CaseyCarter) removed their assignment May 17, 2023
@CaseyCarter
Casey Carter (CaseyCarter) merged commit d95d3bb into microsoft:main May 18, 2023
@CaseyCarter

Copy link
Copy Markdown
Contributor

Thanks! This change has me dancing on the ceiling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<xhash>: reserve() isn't computing the ceiling properly

4 participants