Skip to content

Bump _MSVC_STL_UPDATE for March 2020 - #637

Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
WojciechMigda:yvals_core_h_version_bump_202003
Mar 26, 2020
Merged

Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
microsoft:masterfrom
WojciechMigda:yvals_core_h_version_bump_202003

Conversation

@WojciechMigda

Copy link
Copy Markdown
Contributor

Description

Bump _MSVC_STL_UPDATE for March 2020

Checklist

Be sure you've read README.md and understand the scope of this repo.

If you're unsure about a box, leave it unchecked. A maintainer will help you.

  • Identifiers in product code changes are properly _Ugly as per
    https://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
  • The STL builds successfully and all tests have passed (must be manually
    verified by an STL maintainer before automated testing is enabled on GitHub,
    leave this unchecked for initial submission).
  • These changes introduce no known ABI breaks (adding members, renaming
    members, adding virtual functions, changing whether a type is an aggregate
    or trivially copyable, etc.).
  • These changes were written from scratch using only this repository,
    the C++ Working Draft (including any cited standards), other WG21 papers
    (excluding reference implementations outside of proposed standard wording),
    and LWG issues as reference material. If they were derived from a project
    that's already listed in NOTICE.txt, that's fine, but please mention it.
    If they were derived from any other project (including Boost and libc++,
    which are not yet listed in NOTICE.txt), you must mention it here,
    so we can determine whether the license is compatible and what else needs
    to be done.

@WojciechMigda
WojciechMigda requested a review from a team as a code owner March 25, 2020 23:04
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the enhancement Something can be improved label Mar 25, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I've linked issue #579 to this pull request. In the future, you can say "Fixes #579." in a pull request's description; see GitHub's documentation for "Linking a pull request to an issue using a keyword".

@WojciechMigda

Copy link
Copy Markdown
Contributor Author

Looks good, thanks! I've linked issue #579 to this pull request. In the future, you can say "Fixes #579." in a pull request's description; see GitHub's documentation for "Linking a pull request to an issue using a keyword".

Noted, thanks!

@BillyONeal

Copy link
Copy Markdown
Member

Stephan T. Lavavej (@StephanTLavavej) Should we just set it to April now and say "close enough" given that there won't be a VS release in the next 5 days?

@StephanTLavavej

Copy link
Copy Markdown
Member

Billy O'Neal (@BillyONeal) I'd like April to provide a separate chance for a new GitHub contributor to get comfortable with the pull request process. 😸

@BillyONeal

Copy link
Copy Markdown
Member

Sounds good!

@BillyONeal

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 603971f into microsoft:master Mar 26, 2020
@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for keeping our version macro updated, and congratulations on your first microsoft/STL commit! 😺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to March 2020

4 participants