Skip to content
This repository was archived by the owner on Dec 7, 2021. It is now read-only.

feat: Japanese language support - #922

Merged
P.J. Little (pjlittle) merged 6 commits into
microsoft:developfrom
bart-jansen:bj/add-japanese
Mar 6, 2020
Merged

P.J. Little (pjlittle) merged 6 commits into
microsoft:developfrom
bart-jansen:bj/add-japanese

Conversation

@bart-jansen

Copy link
Copy Markdown
Member

Japanese translation verified by Ayaka Hara (@aykhara) and other native Japanese speakers

@codecov

codecov Bot commented Nov 7, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #922 into develop will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #922     +/-   ##
=========================================
- Coverage     87.9%   87.8%   -0.1%     
=========================================
  Files          129     131      +2     
  Lines         4845    4963    +118     
  Branches       922     984     +62     
=========================================
+ Hits          4259    4358     +99     
- Misses         584     603     +19     
  Partials         2       2
Impacted Files Coverage Δ
src/common/strings.ts 100% <ø> (ø) ⬆️
src/common/localization/ja.ts 100% <100%> (ø)
src/providers/export/pascalVOC.ts 79.44% <0%> (-4.77%) ⬇️
src/providers/export/cntk.ts 96.96% <0%> (-0.65%) ⬇️
src/setupTests.js 100% <0%> (ø) ⬆️
src/providers/export/testAssetsSplitHelper.ts 100% <0%> (ø)
...nents/common/connectionPicker/connectionPicker.tsx 93.54% <0%> (+3.07%) ⬆️
src/common/ipcRendererProxy.ts 66.66% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745e854...09f284e. Read the comment docs.

@PIC123 Phil (PIC123) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wbreza Wallace Breza (wbreza) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this contribution!

Comment thread src/common/localization/ja.ts Resolved
@peaceiris

Copy link
Copy Markdown

Whitespace like the following should be removed.

- ローカル プロジェクトを開く
+ ローカルプロジェクトを開く

Comment thread src/common/localization/ja.ts Resolved
Comment thread src/common/localization/ja.ts Resolved
Comment thread src/common/localization/ja.ts Resolved
Comment thread src/common/localization/ja.ts Resolved
Comment thread src/common/localization/ja.ts Resolved
Comment thread src/common/localization/ja.ts Resolved
Comment thread src/common/localization/ja.ts Resolved
Comment thread src/common/localization/ja.ts Resolved
Comment thread src/common/localization/ja.ts Resolved
@bart-jansen

Bart Jansen (bart-jansen) commented Dec 12, 2019 •

Copy link
Copy Markdown
Member Author

Thanks a lot Shohei Ueda (@peaceiris) ! Really appreciate the feedback, got it verified by Ayaka Hara (@aykhara) and everything looks great and is added in bf0d273

Phil (@PIC123) Wallace Breza (@wbreza) can you guys merge this?

Comment thread src/common/localization/ja.ts Resolved
taggedAssets: "タグ付きアセット(${count})", // Tagged Assets (${count}),
nonTaggedAssets: "タグ付けされていないアセット(${count})", // Not Tagged Assets (${count}),
nonVisitedAssets: " 未訪問ないアセット(${count})", // Not Visited Assets (${count}),
nonVisitedAssets: "未訪問ないアセット(${count})", // Not Visited Assets (${count}),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mentioned removing "ない"...

@sonarqubecloud

sonarqubecloud Bot commented Mar 5, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pjlittle
P.J. Little (pjlittle) changed the base branch from master to develop March 6, 2020 14:50
@pjlittle
P.J. Little (pjlittle) merged commit ed2d28f into microsoft:develop Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants