Repository navigation
feat: Japanese language support - #922
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #922 +/- ##
=========================================
- Coverage 87.9% 87.8% -0.1%
=========================================
Files 129 131 +2
Lines 4845 4963 +118
Branches 922 984 +62
=========================================
+ Hits 4259 4358 +99
- Misses 584 603 +19
Partials 2 2
Continue to review full report at Codecov.
|
Wallace Breza (wbreza)
left a comment
There was a problem hiding this comment.
Looks great, thanks for this contribution!
|
Whitespace like the following should be removed. - ローカル プロジェクトを開く
+ ローカルプロジェクトを開く |
|
Thanks a lot Shohei Ueda (@peaceiris) ! Really appreciate the feedback, got it verified by Ayaka Hara (@aykhara) and everything looks great and is added in bf0d273 Phil (@PIC123) Wallace Breza (@wbreza) can you guys merge this? |
| taggedAssets: "タグ付きアセット(${count})", // Tagged Assets (${count}), | ||
| nonTaggedAssets: "タグ付けされていないアセット(${count})", // Not Tagged Assets (${count}), | ||
| nonVisitedAssets: " 未訪問ないアセット(${count})", // Not Visited Assets (${count}), | ||
| nonVisitedAssets: "未訪問ないアセット(${count})", // Not Visited Assets (${count}), |
There was a problem hiding this comment.
Sorry, I mentioned removing "ない"...
|
Kudos, SonarCloud Quality Gate passed!
|
Japanese translation verified by Ayaka Hara (@aykhara) and other native Japanese speakers