Repository navigation
Normalize directional network input directly - #1383
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
c6b5471 to
987197b
Compare
This PR removes legacy network-format selection after the pre-v0.9 contracts are retired. Shared normalization applies directional policy and proxy sections without changing runtime compatibility or policy identity. Details * Remove unreachable legacy parsing and validation paths. * Keep directional defaults and state-aware network presence behavior. * Test exact-contract rejection of legacy fields and update versioning docs. Tests * cargo fmt --manifest-path .\src\Cargo.toml --all -- --check: passed. * cargo test --manifest-path .\src\Cargo.toml -p wxc_common -p bwrap_common -p nanvix_runner --quiet: passed. * cargo check --manifest-path .\src\Cargo.toml --workspace --all-targets --quiet: passed. * cargo clippy --manifest-path .\src\Cargo.toml -p wxc_common --all-targets -- -D warnings: passed. * Workspace Clippy fails on the unchanged process_container_common unnecessary_sort_by lint in appcontainer_runner.rs:117. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ff6d3538-5272-492f-aba0-5f7ef9feda2f Generated-with: gpt-6-sol
7c737c3 to
34ba787
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The simplified path matches all registered contracts and preserves directional defaults, proxy validation, and state-aware presence semantics.
Review effort: Balanced
Findings: None
What changed in this PR
Simplifies network normalization now that pre-v0.9 contracts are retired.
Changes:
- Removes legacy network format selection and validation.
- Normalizes directional networking directly.
- Adds legacy-field rejection coverage and updates documentation.
| File | Description |
|---|---|
network_parser.rs |
Removes legacy parsing and directly handles directional policy. |
network_parser_loopback_spec_tests.rs |
Removes obsolete legacy loopback tests. |
network_parser_ingress_default_tests.rs |
Updates parser invocation. |
config_parser.rs |
Simplifies normalization and adds contract rejection tests. |
docs/versioning.md |
Documents directional-only normalization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
validator.rs still contains "pub const LEGACY: Self = Self(0);" |
|
Jeff Whiteside (@jsidewhite) Good catch. |
This PR removes obsolete legacy network-format selection after #1382 retires
pre-v0.9 contracts. Shared normalization now applies the directional network
sections directly, without changing runtime compatibility or policy identity.
Details
Test
cargo fmt --manifest-path .\src\Cargo.toml --all -- --check— passed.cargo test --manifest-path .\src\Cargo.toml -p wxc_common -p bwrap_common -p nanvix_runner --quiet— passed (922 shared-crate tests plus backend and integration groups).cargo check --manifest-path .\src\Cargo.toml --workspace --all-targets --quiet— passed.cargo clippy --manifest-path .\src\Cargo.toml -p wxc_common --all-targets -- -D warnings— passed.cargo clippy --manifest-path .\src\Cargo.toml --workspace --all-targets -- -D warnings— failed on pre-existingclippy::unnecessary_sort_byinsrc/backends/process_container/common/src/appcontainer_runner.rs:117; unchanged by this PR.Microsoft Reviewers: Open in CodeFlow