Skip to content

Windows terminal hangs after running ripgrep in a loop #1360

Description

@Treit

Environment

Windows version 1903 OS build 18899.1000
Windows Terminal (Preview) version 0.2.1703.0

Any other software?
ripgrep 11.0.0

Steps to reproduce

Install ripgrep
Open wt (Windows Terminal), running PowerShell.
Run the following from the root of a large drive
while ($true) { rg -i "foo" }

Expected behavior

The terminal continually runs ripgrep against all files on the drive

Actual behavior

The terminal eventually hangs and is completely unresponsive.

The call stack for the main thread when the window hangs is attached.

HungTerminal1.callstack.txt

A minidump of the hung process is available here:
HungWindowsTerminal

Activity

  1. ghost added
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jun 21, 2019
  2. ghost added
    Needs-Tag-FixDoesn't match tag requirements
    on Jun 21, 2019
  3. added
    Area-TerminalControlIssues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    and removed
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Jun 24, 2019
  4. ghost removed
    Needs-Tag-FixDoesn't match tag requirements
    on Jun 24, 2019
  5. miniksa commented on Sep 11, 2019

    @miniksa
    Contributor

    The callstack and dump given appears to be in a state of appropriate locks with output being written to the buffer at the time of the dump/stack break.

    I'm trying to repro this locally to see if I can find something a bit more obvious.

  6. 20 remaining items

  7. ghost added
    In-PRThis issue has a related PR
    on Jan 8, 2020
  8. ghost closed this as completedin #4150on Jan 15, 2020
  9. ghost added a commit that references this issue on Jan 15, 2020
    3e6b4b5
  10. ghost removed
    In-PRThis issue has a related PR
    on Jan 15, 2020
  11. ghost added
    Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.
    on Jan 15, 2020
  12. added a commit that references this issue on Jan 24, 2020
    3b53014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area-QualityStability, Performance, Etc.Area-TerminalControlIssues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)Issue-BugIt either shouldn't be doing this or needs an investigation.Product-TerminalThe new Windows Terminal.Resolution-Fix-CommittedFix is checked in, but it might be 3-4 weeks until a release.Severity-CrashCrashes are real bad news.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions