Repository navigation
AltGr/DeadKey + Space was broken - FIXED IN 1.20.10572.0 #16641
Description
Windows Terminal version
1.20.10303.0
Windows build number
10.0.22635.3130
Other Software
WSL 2.1.1.0
Steps to reproduce
- Using FR bepo keyboard layout
- Typing AltGr + Space in a WSL tab
Expected Behavior
It should type an underscore, since AltGr + Space is the mapping for _ in FR bepo layout.
Actual Behavior
Rings the system bell. Worked fine in Terminal 1.18
Activity
zadjii-msft commentedon Feb 1, 2024
Hmm
James Holderness (@j4james) did this one get regressed in #16511?
j4james commentedon Feb 1, 2024
Yeah, sorry. That's almost certainly a result of PR #16511. We're treating Space as a "functional" key, which means it gets hardcoded VT mappings which take precedence over the keyboard layout. It's not modal, though, so it's possible it could be handled as a regular "graphic" key. However, I have a sneaking suspicion that could break another keyboard layout, and that's why I put it with "functional" keys in the first place. But that may have been an old issue that was resolved in one of my many rewrites. I'll need to do some testing to double check.
j4james commentedon Feb 1, 2024
Unfortunately it's not a simple fix. The reason I chose to handle it as a "functional" key was because the mapping for Ctrl+Space on a number of keyboard layouts is just
SP, while it's expected by VT applications to beNUL. This includes the US layout. So if we handle it as a "graphic" key, that's going to break.Not that that's impossible to fix, but it's likely to be messy.
[-]AltGr + Space not working in WSL with fr-bepo keyboard layout[/-][+]AltGr + Space / Deadkey + Space does not work correctly[/+]ilharp commentedon Feb 2, 2024
All my keypad keys don't work in v1.20, including Enter. I would like to ask if this bug is the same as this issue?
juliencombattelli commentedon Feb 2, 2024
Hello, I just noticed Windows Terminal Preview has the experimental profile option
experimental.connection.passthroughModethat fixes those dead-keys and numpad-keys issues when set totrue(at least on my side). But it is causing other strange behaviors with the arrow keys and CTRL-C as far as I can tell...mveroone commentedon Feb 2, 2024
Hi.
Same issue this morning and I think it's related to Zsh.
I've fixed it this way : https://superuser.com/a/742193/239282
j4james commentedon Feb 2, 2024
Yeah, if you're using zsh, I believe it sets the terminfo
smkxcapability, which enables Keypad Application Mode, and that's what makes the keypad keys generate unique escape sequences. Previous versions of Windows Terminal didn't support that mode, which is why you wouldn't have noticed before. It's not related to this Deadkey+Space issue.Other than manually rebinding the keys, as Maxime Véroone (@mveroone) suggested, another way you might work around the issue is by patching the
zle-line-initfunction to disable the Keypad Application Mode after they've enabled it. Something like this might do the trick:I know almost nothing about zsh, though, so I have no idea what other issues that might cause, but in my brief testing it seemed to work.
I also noticed that ohmyzsh has an open PR to ditch their
smkxusage (ohmyzsh/ohmyzsh#5113), and that should theoretically fix the problem, but that PR is now 8 years old, so it doesn't look like it's happening anytime soon.Improve handling of Space key combinations (#16645)
SchizoDuckie commentedon Feb 21, 2024
Did this stuff get released yet? I feel like a damned idiot every time a switch to a terminal!
[edit]
Nevermind, I was apparently running the Preview build still.
Guess It's time to switch back to the stable build. That solves the issue for me.
Improve handling of Space key combinations (#16645)
[-]AltGr + Space / Deadkey + Space does not work correctly[/-][+]AltGr + Space / Deadkey + Space does not work correctly - FIXED IN 1.20.10572.0[/+][-]AltGr + Space / Deadkey + Space does not work correctly - FIXED IN 1.20.10572.0[/-][+]AltGr/DeadKey + Space was broken - FIXED IN 1.20.10572.0[/+]