Repository navigation
Add IconPicker to New Tab Menu folders in SUI - #19591
Merged
Carlos Zamora (carlos-zamora) merged 6 commits intoFeb 2, 2026
Merged
Conversation
Contributor
Author
Demo
|
This comment was marked as resolved.
This comment was marked as resolved.
Carlos Zamora (carlos-zamora)
marked this pull request as ready for review
December 2, 2025 23:48
Carlos Zamora (carlos-zamora)
added a commit
that referenced
this pull request
Jan 13, 2026
Carlos Zamora (carlos-zamora)
added a commit
that referenced
this pull request
Jan 20, 2026
PankajBhojwani
requested changes
Jan 28, 2026
PankajBhojwani
left a comment
PankajBhojwani
left a comment
Contributor
There was a problem hiding this comment.
Just some minor fixes, looks great!
microsoft-github-policy-service
Bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
Bot
removed
the
Needs-Author-Feedback
Carlos Zamora (carlos-zamora)
added a commit
that referenced
this pull request
Jan 29, 2026
PankajBhojwani
approved these changes
Jan 30, 2026
Carlos Zamora (carlos-zamora)
deleted the
dev/cazamor/sui/ntm-icon-picker
branch
February 2, 2026 19:35
|
|
||
| private: | ||
| Editor::NewTabMenuEntryViewModel _draggedEntry{ nullptr }; | ||
| Editor::IHostedInWindow _windowRoot; |
There was a problem hiding this comment.
doesn't this cause a reference cycle that will result in MainPage being retained, even after navigating away from the NTM page? or am I wrong
Contributor
Author
There was a problem hiding this comment.
Urgh. Yeah, you're right. This should be a weak ref. It'll get fixed in the SUI search PR, but I'll open up a PR rn to fix this. Good catch :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR pulls out the icon picker used in Profiles_Base.xaml to be its own control. Then it's reused as a way to set an icon on folders in the new tab menu.
As a part of pulling out the icon picker into its own control, some minor code-health polish was added (i.e. lazy loading icon types and built in icons).
The new tab menu didn't have a
NavigateToPageArgs, so I took the declaration from #19519 and moved it here. I chose to do that instead of creating aNavigateToNewTabMenuArgssince that's more strict and it would be removed as a part of #19519 anyways.Aside from that, the PR is pretty straightforward.
References and Relevant Issues
Part of #18281
Validation Steps Performed