Skip to content

Stop leaking CPR sequences - #19620

Merged
Dustin L. Howett (DHowett) merged 1 commit into
mainfrom
dev/lhecker/19609-leaked-cpr
Dec 5, 2025
Merged

Stop leaking CPR sequences#19620
Dustin L. Howett (DHowett) merged 1 commit into
mainfrom
dev/lhecker/19609-leaked-cpr

Conversation

@lhecker

@lhecker Leonard Hecker (lhecker) commented Dec 5, 2025

Copy link
Copy Markdown
Member

Due to the IsVtInputEnabled early return, we'd skip
the _captureNextCursorPositionReport by accident.

Closes #19575
Closes #19609

lhecker
Leonard Hecker (lhecker) commented Dec 5, 2025
View reviewed changes
Comment thread src/terminal/parser/InputStateMachineEngine.cpp
Comment on lines +401 to +404
if (vtInputEnabled)
{
return false;
}

@lhecker Leonard Hecker (lhecker) Dec 5, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more verbose than before, but also easier to understand IMO and only 2 more checks than before (3 id comparisons VS 5 if conditions).

@DHowett
Dustin L. Howett (DHowett) merged commit 224ac9d into main Dec 5, 2025
18 of 20 checks passed
@DHowett
Dustin L. Howett (DHowett) deleted the dev/lhecker/19609-leaked-cpr branch January 15, 2026 17:10
@lhecker Leonard Hecker (lhecker) added Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conpty For console issues specifically related to conpty and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett Dustin L. Howett (DHowett) DHowett approved these changes

Assignees

No one assigned

Labels

Area-VT Virtual Terminal sequence support Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conpty For console issues specifically related to conpty

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Escape sequences appearing on new Ubuntu panes Any shortcut prints random signs (even when window is not active)

2 participants

@lhecker @DHowett