Repository navigation
Add AutoProp.Name to font features/axes controls - #19712
Merged
Carlos Zamora (carlos-zamora) merged 1 commit intoJan 7, 2026
Merged
Conversation
|
|
||
| winrt::hstring FontKeyValuePair::AutomationName() | ||
| { | ||
| return hstring{ fmt::format(FMT_COMPILE(L"{}: {}"), KeyDisplayStringRef(), _value) }; |
There was a problem hiding this comment.
What's Ref from?
There was a problem hiding this comment.
Oh. It's just a... it just returns a reference. Sure.
Contributor
Author
There was a problem hiding this comment.
There's two versions: KeyDisplayStringRef() and KeyDisplayString(). They both do the same thing, but there's a funny comment on the Ref version:
terminal/src/cascadia/TerminalSettingsEditor/Appearances.cpp
Lines 138 to 146 in 8f418d1
Dustin L. Howett (DHowett)
approved these changes
Jan 6, 2026
Dustin L. Howett (DHowett)
approved these changes
Jan 6, 2026
Carlos Zamora (carlos-zamora)
enabled auto-merge (squash)
January 6, 2026 23:42
Carlos Zamora (carlos-zamora)
deleted the
dev/cazamor/a11y/font-settings
branch
January 7, 2026 00:41
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Explicitly adds the Name automation property to the list view items (via grid in data template), number boxes, and delete buttons for font features and axes.
Validation Steps Performed
Narrator can read out...
✅ list view items
✅ number boxes
✅ delete button
Also validated using accessibility insights
Closes #19695
Closes #19689