Repository navigation
build: make the PGO build work again; upgrade nuget - #19810
Merged
Dustin L. Howett (DHowett) merged 3 commits intoJan 29, 2026
Merged
Dustin L. Howett (DHowett) merged 3 commits into
Dustin L. Howett (DHowett) merged 3 commits into
Conversation
Dustin L. Howett (DHowett)
force-pushed
the
dev/duhowett/make-the-pgo-publishing-step-work-again
branch
from
January 29, 2026 03:23
a4dee3e to
840a6d6
Compare
|
Well, it takes some time. I'm currently refining the metatable logic to
ensure the audit layer has zero-impact on the renderer's hot path,
especially under extreme buffer stress.
It's a pleasure to work with you! ; )
Dustin L. Howett ***@***.***> 于 2026年1月29日周四 11:23写道:
… Two main changes:
- the build was failing for ARM64 because the build agents run out of
memory downloading artifacts; this is a known issue that nobody cares to
fix (and it pertains to using the x64 emulated agent host on native arm64
machines)
- deleting the PDBs shrinks the build output by 2500MB :P
- we had to switch to a new type of identity for publishing nuget
packages to our cross-org feed
I've verified that we get counts *and* can even produce final PGO count
packages for both architectures!
------------------------------
You can view, comment on, or merge this pull request online at:
#19810
Commit Summary
- cfdfc6c
<cfdfc6c>
PGO - use a FIC?
- 2a50772
<2a50772>
this one IS for checkin
- d5a8413
<d5a8413>
NFCI: use a specific build to run and publish PGO
- 852466e
<852466e>
Revert "NFCI: use a specific build to run and publish PGO"
- 8b49a0d
<8b49a0d>
maybe I don't need the extra config at all
- ce80e0c
<ce80e0c>
Reapply "NFCI: use a specific build to run and publish PGO"
- 1f93f9b
<1f93f9b>
Delete the PDBs
- cb28fa7
<cb28fa7>
Revert "Reapply "NFCI: use a specific build to run and publish PGO""
- 83b468b
<83b468b>
NFCI: branch name
- 4a12b3d
<4a12b3d>
NFCI: pull artifacts from prior run
- c2efe79
<c2efe79>
Force nuget install on arm64
- e802725
<e802725>
Revert "NFCI: pull artifacts from prior run"
- a4dee3e
<a4dee3e>
Revert "NFCI: branch name"
File Changes
(4 files <https://github.com/microsoft/terminal/pull/19810/files>)
- *M* build/pipelines/pgo.yml
<https://github.com/microsoft/terminal/pull/19810/files#diff-87d5fda4f5fef9ec0af867f1c87ac444b9d1cbc2699caaf0202cb6fcfbc09c45>
(1)
- *M* build/pipelines/templates-v2/job-pgo-build-nuget-and-publish.yml
<https://github.com/microsoft/terminal/pull/19810/files#diff-94ab6af006dbcd4c5bfe8ac2eb6d8d1a7ef9f1498a1d54ddefa26ab96eb76d4b>
(20)
- *M* build/pipelines/templates-v2/job-run-pgo-tests.yml
<https://github.com/microsoft/terminal/pull/19810/files#diff-a429888b7e4eb0d3e1768a02d505c0918b0b8344a9f9d51ff8000a458dad2642>
(4)
- *M* build/pipelines/templates-v2/steps-ensure-nuget-version.yml
<https://github.com/microsoft/terminal/pull/19810/files#diff-58eb807cdc916a8058aca201b11eeee9b04cf27c040b7010752b36faa9a703f1>
(11)
Patch Links:
- https://github.com/microsoft/terminal/pull/19810.patch
- https://github.com/microsoft/terminal/pull/19810.diff
—
Reply to this email directly, view it on GitHub
<#19810>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BVYOPYD4IGJTD23RX54FQTT4JF4JRAVCNFSM6AAAAACTIFWALWVHI2DSMVQWIX3LMV43ASLTON2WKOZTHA3DQNJVHAYDEMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Dustin L. Howett (DHowett)
enabled auto-merge (squash)
January 29, 2026 17:43
Carlos Zamora (carlos-zamora)
approved these changes
Jan 29, 2026
Carlos Zamora (carlos-zamora)
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
Dustin L. Howett (DHowett)
deleted the
dev/duhowett/make-the-pgo-publishing-step-work-again
branch
January 29, 2026 20:44
Dustin L. Howett (DHowett)
added a commit
that referenced
this pull request
Jan 29, 2026
Dustin L. Howett (DHowett)
added a commit
that referenced
this pull request
Feb 27, 2026
Two main changes: - the build was failing for ARM64 because the build agents run out of memory downloading artifacts; this is a known issue that nobody cares to fix (and it pertains to using the x64 emulated agent host on native arm64 machines) - deleting the PDBs shrinks the build output by 2500MB :P - we had to switch to a new type of identity for publishing nuget packages to our cross-org feed I've verified that we get counts _and_ can even produce final PGO count packages for both architectures! (cherry picked from commit 8f3d1d8) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgmV1Qg Service-Version: 1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two main changes:
I've verified that we get counts and can even produce final PGO count packages for both architectures!