Skip to content

Allow searching through the available shortcut actions in the EditAction page - #19827

Merged
Dustin L. Howett (DHowett) merged 4 commits into
mainfrom
dev/pabhoj/actions_editor_search
Feb 13, 2026
Merged

Dustin L. Howett (DHowett) merged 4 commits into
mainfrom
dev/pabhoj/actions_editor_search

Conversation

@PankajBhojwani

@PankajBhojwani PankajBhojwani commented Feb 4, 2026 •

Copy link
Copy Markdown
Contributor

Similar to the FontFaceBox, show all the available shortcut actions when the user clicks the ShortcutActionBox, and filter the results based on the user's search query

@PankajBhojwani

Copy link
Copy Markdown
Contributor Author

On first click (no filtering done yet, show all shortcut action types):
image

Updated search results after user types:
image

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 6, 2026
Carlos Zamora (carlos-zamora) added a commit that referenced this pull request Feb 10, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I was thinking more like... we make the allActions list once on navigation and cache that. and then we create _filteredActions based on that.

Right now, this will keep updating ...filtered to be smaller and smaller and e.g. deleting characters from the search won't bring old entries back right? Maybe I've read the code wrong :)

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops i misread

@DHowett

Copy link
Copy Markdown
Member

thank you for letting me know

@PankajBhojwani PankajBhojwani removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 11, 2026
@DHowett
Dustin L. Howett (DHowett) merged commit 527b369 into main Feb 13, 2026
18 of 20 checks passed
@DHowett
Dustin L. Howett (DHowett) deleted the dev/pabhoj/actions_editor_search branch February 13, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants