Repository navigation
Check for command palette's visibility before responding to search text changes - #19885
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
Carlos Zamora (carlos-zamora)
approved these changes
Feb 19, 2026
Carlos Zamora (carlos-zamora)
left a comment
Carlos Zamora (carlos-zamora)
left a comment
Contributor
There was a problem hiding this comment.
Nice find! Thanks for fixing it!
| void CommandPalette::_filterTextChanged(const IInspectable& /*sender*/, | ||
| const Windows::UI::Xaml::RoutedEventArgs& /*args*/) | ||
| { | ||
| // Only respond to this change if we are visible: |
Contributor
There was a problem hiding this comment.
Suggested change
| // Only respond to this change if we are visible: | |
| // GH#19884: Only respond to this change if we are visible: |
Really just a nice way to link up the bug since it provides more context to this fix.
Member
|
Is this, by chance, the same bug as #18737? |
Contributor
Author
Dustin L. Howett (DHowett)
enabled auto-merge (squash)
February 24, 2026 18:18
Dustin L. Howett (DHowett)
approved these changes
Feb 24, 2026
Dustin L. Howett (DHowett)
added this to
1.23 Servicing Pipeline and 1.24 Servicing Pipeline
Dustin L. Howett (DHowett)
deleted the
dev/pabhoj/cmd_pal_preview_fix
branch
February 24, 2026 18:34
Dustin L. Howett (DHowett)
moved this from To Cherry Pick
to Cherry Picked
in 1.24 Servicing Pipeline
Dustin L. Howett (DHowett)
pushed a commit
that referenced
this pull request
Feb 27, 2026
…xt changes (#19885) Only respond to any search changes in the command palette if the command palette is visible. Without this check, a previewable action's preview can appear after the command palette is closed. ## Validation Steps Performed Preview no longer appears after the command palette is closed ## PR Checklist Closes #18737 (cherry picked from commit 1277751) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgmFfaU Service-Version: 1.24
Dustin L. Howett (DHowett)
moved this from Cherry Picked
to Validated
in 1.24 Servicing Pipeline
Dustin L. Howett (DHowett)
moved this from Validated
to Shipped
in 1.24 Servicing Pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Only respond to any search changes in the command palette if the command palette is visible. Without this check, a previewable action's preview can appear after the command palette is closed.
Validation Steps Performed
Preview no longer appears after the command palette is closed
PR Checklist
Closes #18737