⭐ Football Update: microsoft/terminal/pull/

Sagar (sagarbhure-msft) · 2026-03-05T14:28:19Z

Summary of the Pull Request

Fix copyOnSelect right-click paste overwriting the clipboard with a stale selection instead of pasting the current clipboard contents.

Detailed Description of the Pull Request / Additional comments

When copyOnSelect is enabled, the selected text is already copied to the clipboard on left mouse button release in PointerReleased. The selection is intentionally left visible as a visual reference (the _selectionNeedsToBeCopied flag is set to false to track that the copy already happened).

However, the right-click handler in PointerPressed unconditionally called CopySelectionToClipboard() before pasting, ignoring both the copyOnSelect setting and the _selectionNeedsToBeCopied flag. This caused any still-visible selection to be re-copied to the clipboard, overwriting whatever the user may have copied from another application (or another terminal tab) in the meantime.

This change splits the right-click behavior based on the copyOnSelect setting:

copyOnSelect: true — Skip the redundant copy, clear the selection, and paste directly. The text was already copied on mouse-up.
copyOnSelect: false — Preserve existing behavior: copy the selection (if any), clear it, and paste only if there was no selection to copy.

Validation Steps Performed

Set "copyOnSelect": true in settings.json.
Selected text in a terminal pane - verified it was copied to clipboard on mouse-up.
Switched to Notepad, copied different text ("NEW TEXT").
Switched back to Terminal (selection still visible), right-clicked — verified "NEW TEXT" was pasted, not the old selection.
Verified right-click with no active selection still pastes clipboard contents.
Verified right-click immediately after selecting (no app switch) pastes the just-selected text.
Set "copyOnSelect": false — verified right-click still copies selection first, then pastes only when no selection exists (original behavior unchanged).
Verified tab-switching with an active selection does not cause stale clipboard overwrites on right-click.

PR Checklist

Closes #14464 (dupe of #19942)

Sagar (sagarbhure-msft) · 2026-03-10T13:02:11Z

@microsoft-github-policy-service agree

Mike Griese (zadjii-msft) · 2026-03-11T19:45:28Z

Reviewers may want to x-ref this much much older PR of mine:
#14635

Carlos Zamora (carlos-zamora)

Thanks for the x-ref Mike!

Yeah, the same problem from #14635 happens. Blocking over that.

Bug:

ensure copy on select is enabled

enter mark mode

make a selection with mark mode

right-click to copy/paste

expected: selection is copied and pasted immediately

NOTE: similar thing happens when you make a mouse selection, then modify it using quick-edit keys (i.e. shift+right). The selected text is not copied and pasted immediately.

from #14635 (review)

Carlos Zamora (carlos-zamora) · 2026-03-11T20:28:37Z

Root cause from a chat with GH Copilot:

The root cause: _selectionNeedsToBeCopied is only set to true in SetEndSelectionPoint() (mouse drag path, line 699). Mark mode selections go through TryMarkModeKeybinding →
UpdateSelection() → _updateSelectionUI(), which never sets that flag. So for mark mode, the right-click copy was the only opportunity to copy the selection.

Sagar (sagarbhure-msft) · 2026-03-12T15:38:50Z

Thanks for the x-ref Mike!

Yeah, the same problem from #14635 happens. Blocking over that.

Bug:

ensure copy on select is enabled

enter mark mode

make a selection with mark mode

right-click to copy/paste

expected: selection is copied and pasted immediately
NOTE: similar thing happens when you make a mouse selection, then modify it using quick-edit keys (i.e. shift+right). The selected text is not copied and pasted immediately.

from #14635 (review)

ack, looking into this...

Fixes the mark-mode and quick-edit (shift+arrow) bug identified in PR microsoft#14635's review: _selectionNeedsToBeCopied was only set in SetEndSelectionPoint() (mouse drag), so keyboard-driven selections were incorrectly treated as already-copied on right-click. Fix: subscribe to ControlCore::UpdateSelectionMarkers in the ControlInteractivity constructor so the flag is set for ALL selection types (mouse, mark mode, quick-edit, select-all). The right-click handler now uses the same gating logic from PR microsoft#14635 (_selectionNeedsToBeCopied || !copyOnSelect) to decide whether to copy, and always pastes in copyOnSelect mode. Also collapses the if/else into a compact conditional per lhecker's review suggestion. Closes microsoft#14464 Fixes microsoft#19942

Sagar (sagarbhure-msft) · 2026-03-18T13:10:54Z

Pushed a follow-up commit addressing all review feedback:

Leonard Hecker (@lhecker) : collapsed the if/else into a compact conditional as suggested.
Carlos Zamora (@carlos-zamora) : fixed the mark-mode and quick-edit (shift+arrow) bug from Don't copy before pasting in copyOnSelect mode #14635. Root cause was _selectionNeedsToBeCopied only being set in SetEndSelectionPoint() (mouse drag path). Fix: ControlInteractivity now subscribes to UpdateSelectionMarkers so the flag is set for all selection types. The right-click handler uses _selectionNeedsToBeCopied || !copyOnSelect to gate the copy, so mark-mode selections are correctly copied and pasted on right-click

Carlos Zamora (carlos-zamora)

Thank you for doing this! I'll be sure to mark it up for servicing too so that we can get this on all channels in the next update.

…on (#19943) ## Summary of the Pull Request Fix `copyOnSelect` right-click paste overwriting the clipboard with a stale selection instead of pasting the current clipboard contents. ## Detailed Description of the Pull Request / Additional comments When `copyOnSelect` is enabled, the selected text is already copied to the clipboard on left mouse button release in `PointerReleased`. The selection is intentionally left visible as a visual reference (the `_selectionNeedsToBeCopied` flag is set to `false` to track that the copy already happened). However, the right-click handler in `PointerPressed` unconditionally called `CopySelectionToClipboard()` before pasting, ignoring both the `copyOnSelect` setting and the `_selectionNeedsToBeCopied` flag. This caused any still-visible selection to be re-copied to the clipboard, overwriting whatever the user may have copied from another application (or another terminal tab) in the meantime. This change splits the right-click behavior based on the `copyOnSelect` setting: - **`copyOnSelect: true`** — Skip the redundant copy, clear the selection, and paste directly. The text was already copied on mouse-up. - **`copyOnSelect: false`** — Preserve existing behavior: copy the selection (if any), clear it, and paste only if there was no selection to copy. ## Validation Steps Performed 1. Set `"copyOnSelect": true` in `settings.json`. 2. Selected text in a terminal pane - verified it was copied to clipboard on mouse-up. 3. Switched to Notepad, copied different text ("NEW TEXT"). 4. Switched back to Terminal (selection still visible), right-clicked — verified "NEW TEXT" was pasted, not the old selection. 5. Verified right-click with no active selection still pastes clipboard contents. 6. Verified right-click immediately after selecting (no app switch) pastes the just-selected text. 7. Set `"copyOnSelect": false` — verified right-click still copies selection first, then pastes only when no selection exists (original behavior unchanged). 8. Verified tab-switching with an active selection does not cause stale clipboard overwrites on right-click. ## PR Checklist Closes #14465 (dupe of #19942) --------- Co-authored-by: Sagar Bhure <sagarbhure@microsoft.com> (cherry picked from commit ad7b34e) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgn30Lw Service-Version: 1.24

…on (#19943) ## Summary of the Pull Request Fix `copyOnSelect` right-click paste overwriting the clipboard with a stale selection instead of pasting the current clipboard contents. ## Detailed Description of the Pull Request / Additional comments When `copyOnSelect` is enabled, the selected text is already copied to the clipboard on left mouse button release in `PointerReleased`. The selection is intentionally left visible as a visual reference (the `_selectionNeedsToBeCopied` flag is set to `false` to track that the copy already happened). However, the right-click handler in `PointerPressed` unconditionally called `CopySelectionToClipboard()` before pasting, ignoring both the `copyOnSelect` setting and the `_selectionNeedsToBeCopied` flag. This caused any still-visible selection to be re-copied to the clipboard, overwriting whatever the user may have copied from another application (or another terminal tab) in the meantime. This change splits the right-click behavior based on the `copyOnSelect` setting: - **`copyOnSelect: true`** — Skip the redundant copy, clear the selection, and paste directly. The text was already copied on mouse-up. - **`copyOnSelect: false`** — Preserve existing behavior: copy the selection (if any), clear it, and paste only if there was no selection to copy. ## Validation Steps Performed 1. Set `"copyOnSelect": true` in `settings.json`. 2. Selected text in a terminal pane - verified it was copied to clipboard on mouse-up. 3. Switched to Notepad, copied different text ("NEW TEXT"). 4. Switched back to Terminal (selection still visible), right-clicked — verified "NEW TEXT" was pasted, not the old selection. 5. Verified right-click with no active selection still pastes clipboard contents. 6. Verified right-click immediately after selecting (no app switch) pastes the just-selected text. 7. Set `"copyOnSelect": false` — verified right-click still copies selection first, then pastes only when no selection exists (original behavior unchanged). 8. Verified tab-switching with an active selection does not cause stale clipboard overwrites on right-click. ## PR Checklist Closes #14465 (dupe of #19942) --------- Co-authored-by: Sagar Bhure <sagarbhure@microsoft.com> (cherry picked from commit ad7b34e) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgn30Ls Service-Version: 1.25

fix CopyOnSelect

f27eb6d

Sagar (sagarbhure-msft) mentioned this pull request Mar 5, 2026

Right click paste also does a copy with copyOnSelect #19942

Closed

Leonard Hecker (lhecker) reviewed Mar 10, 2026

View reviewed changes

Comment thread src/cascadia/TerminalControl/ControlInteractivity.cpp Resolved

Carlos Zamora (carlos-zamora) suggested changes Mar 11, 2026

View reviewed changes

microsoft-github-policy-service Bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 11, 2026

microsoft-github-policy-service Bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 12, 2026

csdivad mentioned this pull request Mar 17, 2026

Automatically copy selection to clipboard is no longer working correctly with tmux #14464

Closed

Sagar (sagarbhure-msft) requested a review from Carlos Zamora (carlos-zamora) March 19, 2026 17:59

Carlos Zamora (carlos-zamora) approved these changes Mar 19, 2026

View reviewed changes

Carlos Zamora (carlos-zamora) merged commit ad7b34e into microsoft:main Mar 19, 2026
14 of 16 checks passed

Carlos Zamora (carlos-zamora) added this to 1.25 Servicing Pipeline and 1.24 Servicing Pipeline Mar 19, 2026

github-project-automation Bot moved this to To Cherry Pick in 1.24 Servicing Pipeline Mar 19, 2026

github-project-automation Bot moved this to To Cherry Pick in 1.25 Servicing Pipeline Mar 19, 2026

Dustin L. Howett (DHowett) moved this from To Cherry Pick to Cherry Picked in 1.24 Servicing Pipeline Mar 30, 2026

Dustin L. Howett (DHowett) moved this from To Cherry Pick to Cherry Picked in 1.25 Servicing Pipeline Mar 30, 2026

Dustin L. Howett (DHowett) moved this from Cherry Picked to Validated in 1.24 Servicing Pipeline Apr 30, 2026

Dustin L. Howett (DHowett) moved this from Validated to Shipped in 1.24 Servicing Pipeline Apr 30, 2026

Dustin L. Howett (DHowett) moved this from Cherry Picked to Shipped in 1.25 Servicing Pipeline Jun 8, 2026

Navigation Menu

Repository navigation

Fix copyOnSelect right-click overwriting clipboard with stale selection - #19943

Fix copyOnSelect right-click overwriting clipboard with stale selection#19943
Carlos Zamora (carlos-zamora) merged 2 commits into
microsoft:mainfrom
sagarbhure-msft:fix/copyOnSelect-right-click

Sagar (sagarbhure-msft) commented Mar 5, 2026 •

edited by carlos-zamora

Loading

Uh oh!

Sagar (sagarbhure-msft) commented Mar 10, 2026

Uh oh!

Uh oh!

Mike Griese (zadjii-msft) commented Mar 11, 2026

Uh oh!

Carlos Zamora (carlos-zamora) left a comment

Uh oh!

Carlos Zamora (carlos-zamora) commented Mar 11, 2026

Uh oh!

Sagar (sagarbhure-msft) commented Mar 12, 2026

Uh oh!

Sagar (sagarbhure-msft) commented Mar 18, 2026

Uh oh!

Carlos Zamora (carlos-zamora) left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Sagar (sagarbhure-msft) commented Mar 5, 2026 • edited by carlos-zamora Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of the Pull Request

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

PR Checklist

Uh oh!

Sagar (sagarbhure-msft) commented Mar 10, 2026

Uh oh!

Uh oh!

Mike Griese (zadjii-msft) commented Mar 11, 2026

Uh oh!

Carlos Zamora (carlos-zamora) left a comment

Choose a reason for hiding this comment

Uh oh!

Carlos Zamora (carlos-zamora) commented Mar 11, 2026

Uh oh!

Sagar (sagarbhure-msft) commented Mar 12, 2026

Uh oh!

Sagar (sagarbhure-msft) commented Mar 18, 2026

Uh oh!

Carlos Zamora (carlos-zamora) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sagar (sagarbhure-msft) commented Mar 5, 2026 •

edited by carlos-zamora

Loading