Skip to content

Pipenv can't install black because black is only a pre-releaseΒ #5171

New issue
New issue
Closed
Closed
Pipenv can't install black because black is only a pre-release#5171
Assignees
DonJayamannekarrtikr
Labels
area-formattingfeature-requestRequest for new features or functionalitygood first issue
Milestone
2019 - May Sprint 10

Description

@erinxocon
Erin O'Connell (erinxocon)
opened on Apr 9, 2019

Environment data

  • VS Code version: Version 1.34.0-insider
  • Extension version (available under the Extensions sidebar): 2019.3.6558
  • OS and version: macOS 10.14
  • Python version (& distribution if applicable, e.g. Anaconda): project is using 3.7.2, pyenv with global python set to 3.7.3
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): pipenv
  • Relevant/affected Python packages and their versions: black 19.3b0

Expected behaviour

Black installs ok

Actual behaviour

Black fails to install because there are only beta releases and pipenv doesn't look for those by default

Steps to reproduce:

  1. When the popup asks to select a linter, choose black and install it.
  2. Pipenv will fire up and try and install black as a dev package.
  3. Pipenv will fail to install since --pre isn't provided

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Formatting with black failed.
You could either install the 'black' formatter, turn it off or use another formatter.
Error: Module 'black' not installed.

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

Not Applicable

Output from terminal:

pipenv install black --dev      Mon Apr  8 21:53:53 2019
Installing black…
Adding black to Pipfile's [dev-packages]…
βœ” Installation Succeeded 
Pipfile.lock not found, creating…
Locking [dev-packages] dependencies…
✘ Locking Failed! 
[pipenv.exceptions.ResolutionFailure]:   File "/Users/erin/.pyenv/versions/3.7.2/lib/python3.7/site-packages/pipenv/resolver.py", line 70, in resolve
[pipenv.exceptions.ResolutionFailure]:       req_dir=requirements_dir
[pipenv.exceptions.ResolutionFailure]:   File "/Users/erin/.pyenv/versions/3.7.2/lib/python3.7/site-packages/pipenv/utils.py", line 746, in resolve_deps
[pipenv.exceptions.ResolutionFailure]:       req_dir=req_dir,
[pipenv.exceptions.ResolutionFailure]:   File "/Users/erin/.pyenv/versions/3.7.2/lib/python3.7/site-packages/pipenv/utils.py", line 500, in actually_resolve_deps
[pipenv.exceptions.ResolutionFailure]:       resolved_tree = resolver.resolve()
[pipenv.exceptions.ResolutionFailure]:   File "/Users/erin/.pyenv/versions/3.7.2/lib/python3.7/site-packages/pipenv/utils.py", line 415, in resolve
[pipenv.exceptions.ResolutionFailure]:       raise ResolutionFailure(message=str(e))
[pipenv.exceptions.ResolutionFailure]:       pipenv.exceptions.ResolutionFailure: ERROR: ERROR: Could not find a version that matches black
[pipenv.exceptions.ResolutionFailure]:       Skipped pre-versions: 18.3a0, 18.3a0, 18.3a1, 18.3a1, 18.3a2, 18.3a2, 18.3a3, 18.3a3, 18.3a4, 18.3a4, 18.4a0, 18.4a0, 18.4a1, 18.4a1, 18.4a2, 18.4a2, 18.4a3, 18.4a3, 18.4a4, 18.4a4, 18.5b0, 18.5b0, 18.5b1, 18.5b1, 18.6b0, 18.6b0, 18.6b1, 18.6b1, 18.6b2, 18.6b2, 18.6b3, 18.6b3, 18.6b4, 18.6b4, 18.9b0, 18.9b0, 19.3b0, 19.3b0
[pipenv.exceptions.ResolutionFailure]: Warning: Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies.
  First try clearing your dependency cache with $ pipenv lock --clear, then try the original command again.
 Alternatively, you can use $ pipenv install --skip-lock to bypass this mechanism, then run $ pipenv graph to inspect the situation.
  Hint: try $ pipenv lock --pre if it is a pre-release dependency.
ERROR: ERROR: Could not find a version that matches black
Skipped pre-versions: 18.3a0, 18.3a0, 18.3a1, 18.3a1, 18.3a2, 18.3a2, 18.3a3, 18.3a3, 18.3a4, 18.3a4, 18.4a0, 18.4a0, 18.4a1, 18.4a1, 18.4a2, 18.4a2, 18.4a3, 18.4a3, 18.4a4, 18.4a4, 18.5b0, 18.5b0, 18.5b1, 18.5b1, 18.6b0, 18.6b0, 18.6b1, 18.6b1, 18.6b2, 18.6b2, 18.6b3, 18.6b3, 18.6b4, 18.6b4, 18.9b0, 18.9b0, 19.3b0, 19.3b0
There are incompatible versions in the resolved dependencies.
[pipenv.exceptions.ResolutionFailure]:       req_dir=requirements_dir
[pipenv.exceptions.ResolutionFailure]:   File "/Users/erin/.pyenv/versions/3.7.2/lib/python3.7/site-packages/pipenv/utils.py", line 746, in resolve_deps
[pipenv.exceptions.ResolutionFailure]:       req_dir=req_dir,
[pipenv.exceptions.ResolutionFailure]:   File "/Users/erin/.pyenv/versions/3.7.2/lib/python3.7/site-packages/pipenv/utils.py", line 500, in actually_resolve_deps
[pipenv.exceptions.ResolutionFailure]:       resolved_tree = resolver.resolve()
[pipenv.exceptions.ResolutionFailure]:   File "/Users/erin/.pyenv/versions/3.7.2/lib/python3.7/site-packages/pipenv/utils.py", line 415, in resolve
[pipenv.exceptions.ResolutionFailure]:       raise ResolutionFailure(message=str(e))
[pipenv.exceptions.ResolutionFailure]:       pipenv.exceptions.ResolutionFailure: ERROR: ERROR: Could not find a version that matches black
[pipenv.exceptions.ResolutionFailure]:       Skipped pre-versions: 18.3a0, 18.3a0, 18.3a1, 18.3a1, 18.3a2, 18.3a2, 18.3a3, 18.3a3, 18.3a4, 18.3a4, 18.4a0, 18.4a0, 18.4a1, 18.4a1, 18.4a2, 18.4a2, 18.4a3, 18.4a3, 18.4a4, 18.4a4, 18.5b0, 18.5b0, 18.5b1, 18.5b1, 18.6b0, 18.6b0, 18.6b1, 18.6b1, 18.6b2, 18.6b2, 18.6b3, 18.6b3, 18.6b4, 18.6b4, 18.9b0, 18.9b0, 19.3b0, 19.3b0
[pipenv.exceptions.ResolutionFailure]: Warning: Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies.
  First try clearing your dependency cache with $ pipenv lock --clear, then try the original command again.
 Alternatively, you can use $ pipenv install --skip-lock to bypass this mechanism, then run $ pipenv graph to inspect the situation.
  Hint: try $ pipenv lock --pre if it is a pre-release dependency.
ERROR: ERROR: Could not find a version that matches black
Skipped pre-versions: 18.3a0, 18.3a0, 18.3a1, 18.3a1, 18.3a2, 18.3a2, 18.3a3, 18.3a3, 18.3a4, 18.3a4, 18.4a0, 18.4a0, 18.4a1, 18.4a1, 18.4a2, 18.4a2, 18.4a3, 18.4a3, 18.4a4, 18.4a4, 18.5b0, 18.5b0, 18.5b1, 18.5b1, 18.6b0, 18.6b0, 18.6b1, 18.6b1, 18.6b2, 18.6b2, 18.6b3, 18.6b3, 18.6b4, 18.6b4, 18.9b0, 18.9b0, 19.3b0, 19.3b0
There are incompatible versions in the resolved dependencies.

Proposed solution:

  1. Add the --pre flag to the pipenv command when black is chosen and installed.

Activity

  1. ghost added
    triage-neededNeeds assignment to the proper sub-team
    on Apr 9, 2019

  2. erinxocon commented on Apr 9, 2019

    @erinxocon
    Erin O'Connell (erinxocon)
    on Apr 9, 2019
    Author

    I propose adding a very very simple clause to https://github.com/erinxocon/vscode-python/blob/e441ed614fe9ccda1818e19acbba5ab8d82d772c/src/client/common/installer/pipEnvInstaller.ts#L33

            const args = ['install', moduleName, '--dev'];
        if (moduleName === 'black') {
            args.push('--pre');
        }
        return {
            args: args,
            execPath: pipenvName
        };

    I am concerned though, this places the burden on the VS Code development team when black comes out with a non-pre version. The other option could be to instruct the user to do this manually passing the --pre flag. The reason I bring this up is that I believe, and Dan Ryan (@techalchemy) can correct me if I'm wrong, but when --pre is passed as an argument this applies to the whole locking process and any package that has a pre-releases would end up being resolved and installed when the user might not expect.

  3. Eric Snow (ericsnowcurrently)
    added
    area-formatting
    good first issue
    needs PR
    feature-requestRequest for new features or functionality
    on Apr 9, 2019
  4. ghost removed
    triage-neededNeeds assignment to the proper sub-team
    on Apr 9, 2019

  5. ericsnowcurrently commented on Apr 9, 2019

    @ericsnowcurrently
    Eric Snow (ericsnowcurrently)
    on Apr 9, 2019

    Erin O'Connell (@erinxocon), thanks for letting us know about this. We'll look into it.

  6. erinxocon commented on Apr 9, 2019

    @erinxocon
    Erin O'Connell (erinxocon)
    on Apr 9, 2019
    Author

    Eric Snow (@ericsnowcurrently) thanks! I'm willing to work on a PR once a decision is reached on how to handle this edge case. I helped develop pipenv and am very familiar with it's workings 🌈🍰🌈

  7. DonJayamanne commented on Apr 10, 2019

    @DonJayamanne
    Don Jayamanne (DonJayamanne)
    on Apr 10, 2019

    this applies to the whole locking process and any package that has a pre-releases would end up being resolved and installed when the user might not expect.

    Agreed, we will have to make an exception with black
    Please feel free to submita PR with the pre flag just for black.
    I.e. your suggestion is perfect

  8. Brett Cannon (brettcannon)
    added this to the 2019 - April Sprint 9 milestone on Apr 25, 2019
  9. Brett Cannon (brettcannon)
    added
    external contributor
    on Apr 25, 2019
  10. Don Jayamanne (DonJayamanne)
    self-assigned this
    on Apr 25, 2019
  11. Kartik Raj (karrtikr)
    self-assigned this
    on May 9, 2019
  12. Don Jayamanne (DonJayamanne)
    modified the milestones: 2019 - April Sprint 9, 2019 - May Sprint 10 on May 9, 2019
  13. Don Jayamanne (DonJayamanne)
    closed this as completedon May 20, 2019
  14. ghost removed
    needs PR
    on May 20, 2019
  15. lock
    locked as resolved and limited conversation to collaborators on Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-formattingfeature-requestRequest for new features or functionalitygood first issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions