Sandbox: explore how to support direct helper process to renderer communication #131798

Activity

1. Benjamin Pasero (bpasero)

   assigned

   Robo (deepak1556)

   on Aug 27, 2021
2. Benjamin Pasero (bpasero)

   added

   sandboxRunning VSCode in a node-free environmentRunning VSCode in a node-free environment

   on Aug 27, 2021
3. Benjamin Pasero (bpasero)

   changed the title [-]Explore how to support node.js processes from Electron that can talk directly to a `BrowserWindow` (to convert shared process into a node.js process)[/-] [+]Sandbox: explore how to support direct helper process to renderer communication[/+] on Aug 27, 2021
4. Tyriar commented on Aug 27, 2021

   

   Daniel Imms (Tyriar)

   on Aug 27, 2021

   Contributor

   More actions

   Robo (@deepak1556) any update on this? Do we have an upstream issue we can link?
5. Benjamin Pasero (bpasero)

   added this to the November 2021 milestone on Oct 17, 2021
6. Robo (deepak1556)

   modified the milestones: November 2021, December 2021 on Nov 29, 2021
7. Robo (deepak1556)

   modified the milestones: January 2022, February 2022 on Jan 28, 2022
8. Robo (deepak1556)

   modified the milestones: February 2022, March 2022 on Feb 24, 2022
9. Robo (deepak1556)

   modified the milestones: March 2022, April 2022 on Mar 23, 2022
10. deepak1556 commented on Apr 27, 2022

    

    Robo (deepak1556)

    on Apr 27, 2022

    Last edited by deepak1556

    Collaborator

    More actions

    Prototype demonstrating communication between Node integration enabled chromium service process and sandbox renderer is complete.

    Link: https://streamable.com/tqozwr

    Current state of API:

    // Main Process
    interface ProcessOptions {
     displayName?: string | undefined;
     execArgv?: string[] | undefined;
     env?: NodeJS.ProcessEnv | undefined;
    }
    
    interface MessageEvent {
      data: any;
    }
    
    class UtilityProcess extends NodeJS.EventEmitter {
    
     constructor(modulePath: string, args?: string[] | undefined, options?: ProcessOptions);
    
     readonly pid?: number | undefined;
    
     /*
      * Pending Implementation
     postMessage(channel: string, message: any, transfer?: Electron.MessagePortMain[]): void;
      */
    
     kill(signal: number): boolean;
    
     /*
      * Pending Implementation
     on(event: 'message', listener: (event: MessageEvent) => void): this;
      */
     
     on(event: 'exit', listener: (code: number) => void): this;
    
     on(event: 'spawn', listener: (void) => void): this;
    }
    
    // Service Process
    interface MessageEvent {
     data: any;
     ports: MessagePortMain[];
    }
    
    interface Process extends NodeJS.EventEmitter {
    
     on(channel: string, listener: (event: MessageEvent) => void): this;
    
     /*
      * Pending Implementation
     send(message: any);
      */
    }

    🎉React with 🎉3Reacted by Benjamin Pasero, Safa Sofuoglu and Yukai Huang
11. deepak1556 commented on Apr 27, 2022

    

    Robo (deepak1556)

    on Apr 27, 2022

    Last edited by deepak1556

    Collaborator

    More actions

    Next Steps in order:

    • Create custom builds with the new API
    • Implement extension host with the above API (refs vscode#135268) and iron out edge cases if any
    • Send RFC PR to https://github.com/electron/governance/tree/main/wg-api/spec-documents
    • Upstream implementation PR to https://github.com/electron/electron
12. Robo (deepak1556)

    modified the milestones: April 2022, May 2022 on Apr 27, 2022
13. safasofuoglu commented on Apr 27, 2022

    

    Safa Sofuoglu (safasofuoglu)

    on Apr 27, 2022

    More actions

    Will this work enable shareable non-copy buffers, rather than one-way ownership transfer?
14. Robo (deepak1556)

    modified the milestones: May 2022, June 2022 on Jun 2, 2022
15. Robo (deepak1556)

    removed this from the June 2022 milestone on Jun 30, 2022
16. deepak1556 commented on Jul 5, 2022

    

    Robo (deepak1556)

    on Jul 5, 2022

    Collaborator

    More actions

    Exploration is complete and extension host has adopted this behind a setting. Next steps continued in #154007
17. Robo (deepak1556)

    closed this as completedon Jul 5, 2022
18. github-actions

    locked and limited conversation to collaborators on Aug 19, 2022