Skip to content

Allow to enable sandbox behind a setting and validate it worksΒ #154006

Closed

Description

The idea is to eventually enable this by default in insiders.

Things to check:

  • πŸƒ There are no issues from the contextBridge when using the exposed API from our preload script
  • πŸƒ Investigate the impact on running as admin when sandbox: true
  • πŸƒ Performance validation & tuning

Activity

  1. changed the title [-]Allow to enable `sandbox` behind a setting[/-] [+]Allow to enable `sandbox` behind a setting and validate it works[/+] on Jul 3, 2022
  2. bpasero commented on Jul 5, 2022

    @bpasero
    ContributorAuthor

    From Robo (@deepak1556) on running as admin:

    Running the application as elevated on macOS and windows will work, the problematic scenarios are the following,

    • On Linux, if a user the installed the application as root technically they should be able to launch the application but the issue would be the sandbox will now run under admin privilege and access to files which are owned by a different user will fail and most often the user data directory would not be owned by root and chrome's internal logic would abort when not being able to read/write to this folder.
    • The second scenario on linux is when application was installed as normal user but then tried to launch with sudo, in this case the sandbox which uses execve would fail to stat the executable after launching a process and lead to a hard crash. This makes chrome unable to launch child processes. The decision was then made to never allow running as elevated on linux under sandbox, https://bugs.chromium.org/p/chromium/issues/detail?id=638180
    • On Windows, when running the application as elevated while applocker is enabled will cause the sandboxed process to fail launch https://bugs.chromium.org/p/chromium/issues/detail?id=740132
  3. bpasero commented on Jul 21, 2022

    @bpasero
    ContributorAuthor

    Test plan item: #155827

  4. locked and limited conversation to collaborators on Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

on-testplanplan-itemVS Code - planned item for upcomingsandboxRunning VSCode in a node-free environment

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions