Repository navigation
fix: keep annotations of nested suites with group_reports disabled - #1649
Merged
mikepenz merged 1 commit intoNov 6, 2026
Merged
Conversation
With `group_reports: false` the per-file result took `annotations` and `testResults` straight from the root suite of the report. `annotations` only holds the test cases of the root itself, so reports with a `<testsuites>` root (pytest, jest-junit, go-junit-report, ...) published a check without annotations and summaries without rows, although the title listed the failures. `testResults` skipped the root itself, which hid the test cases of a root `<testsuite>` from the details with `group_suite`. Move the mapping to `ungroupTestResult`, collect the annotations of nested suites like `module_reports` does, and keep the root suite in `testResults`. Rebuild dist. Fixes mikepenz#1647
mikepenz
force-pushed
the
fix/ungrouped-nested-annotations
branch
from
November 6, 2026 13:55
e75a57c to
6e4289e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1647
Problem
With
group_reports: false, the per-file result takesannotationsandtestResultsfrom the root suite of the report.annotationsonly holds the root's own test cases, so reports with a<testsuites>root (pytest, jest-junit, go-junit-report, ...) lose all their annotations: the check run has none although its title lists failures, and the detailed and flaky summaries have no rows for that file.testResultsskips the root itself, so withgroup_suite: truethe test cases of a root<testsuite>(e.g. surefire) are missing from the detailed summary.Fix
ungroupTestResultnext toaddToModuleResults, replacing the inline mapping inmain.ts.globalAnnotationsusescollectAnnotations, the helper that fixed the same problem formodule_reports.testResultsis[actual], so the root suite is included, as in grouped mode andmodule_reports. Reports whose root has no test cases of its own render the same grouped details as before.Tests
New
ungrouped reportstests in__tests__/testParser.test.ts: one result per file, annotations from nested suites, root suite test cases in the grouped details table. All three fail with the old mapping.npm run allpasses (128 tests). I also ran the packaged action against a local fake of the checks API withtest_results/python/report.xmlandgroup_reports: false:dist/was rebuilt withnpm run package.