Repository navigation
Resolve the enforcer rule's signature through Maven Resolver - #367
Merged
Merged
Conversation
Drops the maven-compat ArtifactResolver and ArtifactFactory, matching how check-signature resolves its signature.
slachiewicz
marked this pull request as ready for review
October 12, 2026 10:57
20 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enforcer rule now resolves its signature with
RepositorySystemand the project's remote repositories, ascheck-signaturealready does, and the module no longer depends onmaven-compat.Signature.createArtifact()now returns a Resolver artifact and takes no argument.Verified:
mvn -Prun-its verify -pl animal-sniffer-enforcer-rule -amβ 3/3 ITs pass on Maven 3.9.16 and 4.0.0-rc-7; smoke-test resolves both signatures.