Skip to content

BanDuplicateClasses Performance IssueΒ #122

Closed

Description

@thomasnikolay

We have a large Dependency with some big dependencies. The check for BanDuplicateClasses tooks over 10 minutes. The check consume the most time in

InputStream inputStream = jar.getInputStream( jar.getEntry( classFilePath ) );
to extract the file from the JAR for generating the hash value.

image

Is it possible to optimize this behavior? I think to cache the JAR could help instead of to read the JAR for each file again.

Activity

  1. added a commit that references this issue on Jun 26, 2022
    3d0acea
  2. slawekjaranowski commented on Jun 26, 2022

    @slawekjaranowski
    Member

    @thomasnikolay if you can - please check rule code from PR on your project, should be better.

  3. added a commit that references this issue on Jul 1, 2022
    af6cc58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions