Skip to content

Make parent level configurable for reference value in requirePropertyDiverges - #295

Merged
slawekjaranowski merged 3 commits into
mojohaus:masterfrom
piercemar:requirePropertyDiverges_reference
Mar 19, 2024
Merged

Make parent level configurable for reference value in requirePropertyDiverges#295
slawekjaranowski merged 3 commits into
mojohaus:masterfrom
piercemar:requirePropertyDiverges_reference

Conversation

@piercemar

@piercemar piercemar commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Enhancement proposal for rule requirePropertyDiverges

As proposed in #282 to @slawekjaranowski

Adds a new, optional <reference> parameter which can take 3 values:

  • DEFINING (current behaviour, default)
  • PARENT use direct parent as reference context
  • BASE use topmost local POM as reference context

Tests & doc included

@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Mar 15, 2024
@slawekjaranowski slawekjaranowski self-assigned this Mar 19, 2024
@slawekjaranowski slawekjaranowski linked an issue Mar 19, 2024 that may be closed by this pull request
RequirePropertyDiverges evaluates in own context #282
Closed
@slawekjaranowski
slawekjaranowski merged commit 4d399e8 into mojohaus:master Mar 19, 2024
@piercemar

piercemar commented Mar 19, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for accepting the PR @slawekjaranowski. Looking forward for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees

@slawekjaranowski slawekjaranowski

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RequirePropertyDiverges evaluates in own context

2 participants

@piercemar @slawekjaranowski