Repository navigation
Send a plugin-specific User-Agent when downloading licenses - #728
Merged
Merged
Conversation
gnu.org answers the Apache HttpClient default user agent with "429 Too Many Requests" on the very first request, so downloads from one of the most frequently referenced license hosts never succeed. Co-authored-by: Jan-Hendrik Diederich <1955253+Master-Code-Programmer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnu.org answers the Apache HttpClient default user agent with
429 Too Many Requestson the very first request, sodownload-licensesnever retrieves a license from one of the most frequently referenced hosts. The plugin now identifies itself aslicense-maven-plugin/<version>, taken from the jar manifestImplementation-Version.Extracted from #622, where @Master-Code-Programmer diagnosed the cause. That PR sends
Wget/1.21.4; it also adds anhttps://and then plaintexthttp://retry for protocol-less license URLs, which is a separate behaviour change and stays out of this PR.Verified:
mvn verify -Prun-its -Dinvoker.test=download-licenses-authpasses, and reverting only theLicenseDownloaderchange fails the new assertion withUser-Agent: Apache-HttpClient/4.5.14 (Java/25.0.4).This change was created with AI assistance.