Repository navigation
Keep blank lines of the license when reading an existing header - #808
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading an existing header skipped every empty line, so with
trimHeaderLinea secondupdate-file-headerrun that changed another part of the header dropped the blank lines of the license text. Only the comment start and end lines are skipped now. The newISSUE-347integration test runs the goal twice on an HTML file.Closes #347
Verified:
mvn -B -ntp verify -Prun-its -Dinvoker.test=ISSUE-347,update-file-header-test-mojo→ 176 unit tests, 2 ITs passed; ISSUE-347 fails without the fix