Skip to content

Include Last-Modified header in the response - #117

Merged
slawekjaranowski merged 1 commit into
mojohaus:masterfrom
corgibytes:last-modified-header
Aug 16, 2022
Merged

slawekjaranowski merged 1 commit into
mojohaus:masterfrom
corgibytes:last-modified-header

Conversation

@mscottford

Copy link
Copy Markdown
Contributor

I'm authoring a library, dependency-history-maven that can query HTTP Maven repositories to determine the release history for a particular package. That library is using the Last-Modified header value to determine when a file was released into the repository. I'm also working on an integration of this library into a Maven plugin that uses mrm for its integration tests, so I need mrm to include the Last-Modified header for those tests to work.

@slawekjaranowski

Copy link
Copy Markdown
Member

Is it possible to to add some test for it?

@mscottford

Copy link
Copy Markdown
Contributor Author

I didn't see any tests for the servlet, and I wasn't sure the best way to go about adding them.

@slawekjaranowski

Copy link
Copy Markdown
Member

Yes I know, there tests are missing ...
So I only ask, it will be possible to add one.

I see eg, that method doGet has many responsibility, like

  • provide settings
  • provide data for FileEntry and DirectoryEntry

we can split it to separate method and it will be simple to test

But yes such improvement can be don in separate PR.

@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Aug 16, 2022
@slawekjaranowski
slawekjaranowski merged commit c3644f0 into mojohaus:master Aug 16, 2022
@mscottford

Copy link
Copy Markdown
Contributor Author

Awesome! Thanks for merging this in. Any estimate on when this will be included in a published release?

@slawekjaranowski

Copy link
Copy Markdown
Member

I don't have plan to release new version now, last was two months ago.

But you can try to incentive me, eg by more improvement in code, documentations, ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants