Repository navigation
Include Last-Modified header in the response - #117
Merged
slawekjaranowski merged 1 commit intoAug 16, 2022
Merged
Conversation
Member
|
Is it possible to to add some test for it? |
Contributor
Author
|
I didn't see any tests for the servlet, and I wasn't sure the best way to go about adding them. |
Member
|
Yes I know, there tests are missing ... I see eg, that method doGet has many responsibility, like
we can split it to separate method and it will be simple to test But yes such improvement can be don in separate PR. |
Contributor
Author
|
Awesome! Thanks for merging this in. Any estimate on when this will be included in a published release? |
Member
|
I don't have plan to release new version now, last was two months ago. But you can try to incentive me, eg by more improvement in code, documentations, ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm authoring a library, dependency-history-maven that can query HTTP Maven repositories to determine the release history for a particular package. That library is using the
Last-Modifiedheader value to determine when a file was released into the repository. I'm also working on an integration of this library into a Maven plugin that usesmrmfor its integration tests, so I needmrmto include theLast-Modifiedheader for those tests to work.