Skip to content

basePath configuration parameter - #94

Merged
ppalaga merged 1 commit into
mojohaus:masterfrom
ppalaga:220526-context-path
Jun 2, 2022
Merged

ppalaga merged 1 commit into
mojohaus:masterfrom
ppalaga:220526-context-path

Conversation

@ppalaga

@ppalaga ppalaga commented May 26, 2022

Copy link
Copy Markdown
Contributor

This adds basePath config parameter defined as follows:

    /**
     * The base path under which the repository will be served.
     * <p>
     * By default, {@code org.acme:my-artifact:pom:1.2.3} will be served under
     * {@code http://localhost:<port>/org/acme/my-artifact/1.2.3/my-artifact-1.2.3.pom}.
     * <p>
     * If {@code basePath} is set to e.g. {@code foo/bar} then {@code org.acme:my-artifact:pom:1.2.3} will be served
     * under {@code http://localhost:<port>/foo/bar/org/acme/my-artifact/1.2.3/my-artifact-1.2.3.pom}.
     */
    @Parameter( property = "mrm.basePath", defaultValue = "/" )
    private String basePath;

On my side, this is motivated by a need to have caching proxy of some company-internal maven repo for a tool (namely PNC Bacon PiG ) that only allows configuring the protocol host and port of the repo (here), but assumes a fixed base path.

@ppalaga

ppalaga commented May 26, 2022

Copy link
Copy Markdown
Contributor Author

Would anybody like to review?

@ppalaga

ppalaga commented Jun 1, 2022

Copy link
Copy Markdown
Contributor Author

Any chance to review @olamy @slawekjaranowski or @hboutemy ?

@slawekjaranowski

Copy link
Copy Markdown
Member

LGTM
the new line at the end of some files are missing πŸ˜„

@ppalaga
ppalaga force-pushed the 220526-context-path branch 2 times, most recently from ed93f3e to a7a4901 Compare June 1, 2022 18:46
@ppalaga

ppalaga commented Jun 1, 2022 •

Copy link
Copy Markdown
Contributor Author

Thanks for the review @slawekjaranowski!

e16e909:

  • Added file-final EOLs where necessary
  • s/3.2.2/@maven-invoker-plugin.version@/
  • s/3.8.1/@maven-compiler-plugin.version@/

@ppalaga
ppalaga force-pushed the 220526-context-path branch from a7a4901 to e16e909 Compare June 1, 2022 19:12
@ppalaga

ppalaga commented Jun 1, 2022

Copy link
Copy Markdown
Contributor Author

I'd merge tomorrow unless somebody finds something to fix till then

@ppalaga
ppalaga merged commit 4c375aa into mojohaus:master Jun 2, 2022
@ppalaga ppalaga mentioned this pull request Jun 2, 2022
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants