Repository navigation
Added remaining javadoc comments. - #1293
Merged
Merged
Conversation
andrzejj0
added
documentation
andrzejj0
marked this pull request as draft
October 15, 2025 06:27
andrzejj0
force-pushed
the
more-javadoc
branch
from
October 15, 2025 06:31
861e1bc to
ff1cf78
Compare
Contributor
Author
|
Looks like that I can't make javadoc plugin actually see already compiled dependencies; even rearranging modules in parent won't help. I'll remove the additional linter step in favor of a slightly less lenient checks. |
andrzejj0
marked this pull request as ready for review
October 15, 2025 07:24
- Supressing javadoc linter problems during report generation. - Additional javadoc linting step where these are suppressed (it's not possible to have two executions in reporting)
andrzejj0
force-pushed
the
more-javadoc
branch
from
October 18, 2025 07:49
b69a340 to
6d115dd
Compare
slachiewicz
approved these changes
Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also:
- Additional javadoc linting step where these are suppressed (it's not possible to have two executions in reporting)Currently I'm also enforcing Javadoc correctness, but I'm thinking whether it's not better to just have a lenient linter everywhere.
@slawekjaranowski please approve/advise.