Repository navigation
Resolve property versions in parallel - #1447
Merged
Merged
Conversation
This was referenced Oct 11, 2026
slachiewicz
marked this pull request as ready for review
October 11, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1157. Part of #1445. The property goals (
update-properties,update-property,display-property-updates,set-propertyand the property reports) looked up the versions of one property after another.getVersionPropertiesMapnow prepares and logs each property in order as before, then resolves them on the bounded pool the helper already uses for dependency and plugin lookups (5 threads). The result keeps the property order, and the first failing property's error is reported as before. Within one property, its associated artifacts are still looked up in sequence.Verified:
DefaultVersionsHelperTest#testVersionPropertiesMapLooksUpPropertiesConcurrentlyblocks every lookup until four are in flight; it times out without this change and passes with it.