Repository navigation
Read a parent plugin declared in several profiles once - #1494
Merged
Merged
Conversation
Since parent plugins without <inherited> count as inherited (#1488), a report plugin declared in two profiles of a parent reached Collectors.toMap twice and failed with a duplicate key. The last declaration wins, as it already does for build plugins and plugin management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1490, a regression in 2.25.1.
Since #1488 treats a parent plugin without
<inherited>as inherited, a report plugin declared in two profiles of a parent POM reachesCollectors.toMaptwice, anddisplay-plugin-updatesfails with "Duplicate key ... (attempted merging values 3.6.0 and 3.6.0)". The last declaration now wins, as it already does for build plugins and plugin management; the build-plugin reader gets the same merge function. The new IT declares one report plugin in two profiles of the parent.Verified:
display-plugin-updateson the reporter'sversions-maven-plugin-2.25.1-regressionbranch → 2.25.1 fails with the duplicate key, this branch succeeds.