Repository navigation
Reclaim native memory quicker when using ZlibCompressor - #1285
Merged
Merged
Conversation
…n the deflater, since by supplying a deflater to the constructor of DeflaterOutputStream usesDefaultDeflater is set to false and therefore end() is not invoked in DeflaterOutputStream#close.
Collaborator
jyemin
approved these changes
Jan 10, 2024
jyemin
left a comment
jyemin
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Just one whitespace issue to fix.
jyemin
pushed a commit
that referenced
this pull request
Jan 10, 2024
Reclaim native memory quicker by overriding close() on DeflaterOutputStream to invoke end() on the Deflater, since by supplying a deflater to the constructor of DeflaterOutputStream usesDefaultDeflater is set to false and therefore end() is not invoked in DeflaterOutputStream#close. JAVA-5280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reclaim native memory quicker by overriding
close()to invokeend()on the deflater, since by supplying a deflater to the constructor ofDeflaterOutputStreamusesDefaultDeflateris set tofalseand thereforeend()is not invoked in DeflaterOutputStream#close.This is related to JDK-4797189 bug/feature (marked as Won't Fix)
See the following blog post for more information: https://medium.com/swlh/native-memory-the-silent-jvm-killer-595913cba8e7
JAVA-5280