Skip to content

Account the time to deliver connection pool events as part of the reported duration - #1290

Merged
stIncMale merged 2 commits into
mongodb:masterfrom
stIncMale:JAVA-5121
Jan 5, 2024
Merged

stIncMale merged 2 commits into
mongodb:masterfrom
stIncMale:JAVA-5121

Conversation

@stIncMale

@stIncMale stIncMale commented Jan 3, 2024 •

Copy link
Copy Markdown
Member

@stIncMale
stIncMale requested review from jyemin and rozza January 3, 2024 20:23
@stIncMale stIncMale self-assigned this Jan 3, 2024
Comment on lines +513 to +519
TimePoint tConnectionCreated = TimePoint.now();
logEventMessage("Connection created",
"Connection created: address={}:{}, driver-generated ID={}",
connectionId.getLocalValue());

connectionPoolListener.connectionCreated(new ConnectionCreatedEvent(connectionId));
return TimePoint.now();
return tConnectionCreated;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change, and a similar change in the connectionCheckoutStarted method are the only behavioral changes in the PR.

@stIncMale
stIncMale requested a review from jyemin January 4, 2024 21:43
@jyemin
jyemin removed the request for review from rozza January 5, 2024 19:55
@jyemin

jyemin commented Jan 5, 2024

Copy link
Copy Markdown
Collaborator

One reviewer is sufficient for this. Removed @rozza

@stIncMale
stIncMale merged commit 42fdd3f into mongodb:master Jan 5, 2024
@stIncMale
stIncMale deleted the JAVA-5121 branch January 5, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants