Skip to content
This repository was archived by the owner on Nov 1, 2022. It is now read-only.

Closes issue #8363: Call startForegroundService instead of startService on DownloadMiddleware - #8364

Merged
bors[bot] merged 1 commit into
mozilla-mobile:masterfrom
Amejia481:issue-8363
Sep 9, 2020
Merged

Closes issue #8363: Call startForegroundService instead of startService on DownloadMiddleware#8364
bors[bot] merged 1 commit into
mozilla-mobile:masterfrom
Amejia481:issue-8363

Conversation

@Amejia481

@Amejia481 Amejia481 commented Sep 9, 2020 •
edited by rocketsroger
Loading

Copy link
Copy Markdown
Contributor

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@Amejia481 Amejia481 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Sep 9, 2020
@Amejia481 Amejia481 mentioned this pull request Sep 9, 2020
Closed
rocketsroger
rocketsroger approved these changes Sep 9, 2020
View reviewed changes

@rocketsroger rocketsroger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@rocketsroger rocketsroger added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed labels Sep 9, 2020
@Amejia481

Amejia481 commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

bors r=rocketsroger

bors Bot pushed a commit that referenced this pull request Sep 9, 2020
@MozLando @Amejia481
Merge #8364
8126a6b 
8364: Closes issue #8363: Call startForegroundService instead of startService on DownloadMiddleware r=rocketsroger a=Amejia481




Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
@bors

bors Bot commented Sep 9, 2020

Copy link
Copy Markdown

Timed out.

@Amejia481

Amejia481 commented Sep 9, 2020

Copy link
Copy Markdown
Contributor Author

bors retry

@bors

bors Bot commented Sep 9, 2020

Copy link
Copy Markdown

Build succeeded:

@bors
bors Bot merged commit 81f0f80 into mozilla-mobile:master Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@rocketsroger rocketsroger rocketsroger approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rocketsroger rocketsroger

Labels

🛬 needs landing PRs that are ready to land

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Amejia481 @rocketsroger