Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] text contrast ratio of top sites labels is too lowΒ #13850

Closed

Description

@willfs84

The contrast ratio of the top sites labels is too low especially when you consider how small a font size is being used. Screenshot comparison of Firefox, Chrome and Edge. Notice that both Chrome and Edge have significantly larger font size as well as higher contrast ratio. Look at Firefox vs Edge especially, there's a massive difference there :(

topsitestextcontrastratio

┆Issue is synchronized with this Jira Task

Activity

  1. willfs84 commented on Aug 14, 2020

    @willfs84
    Author

    Oops I forgot to add: I'm pretty sure this contrast ratio/text size combination doesn't meet accessibility minimums

  2. mcarare commented on Aug 17, 2020

    @mcarare
    Contributor

    Using Accessibility Scanner there are no recommendations for the top sites label. The text is indeed smaller than 12sp, but that was a design decision.

  3. added
    accessAccessibility: Talkback, HW keyboard/mouse, braile display etc.
    and removed
    accessAccessibility: Talkback, HW keyboard/mouse, braile display etc.
    on Aug 20, 2020
  4. liuche commented on Aug 20, 2020

    @liuche
    Contributor

    hi @asadotzler is there an a11y recommendation here? This wasn't on any of the a11y lists, but let me know if you have a recommendation here (and possibly a priority as well).

  5. changed the title [-][Bug] text contrast ratio of top sites labels is too low[/-] [+][Bug] Improve colour contrast ratio of caption and secondary texts (like Top Sites labels)[/+] on Sep 16, 2020
  6. changed the title [-][Bug] Improve colour contrast ratio of caption and secondary texts (like Top Sites labels)[/-] [+][Bug] text contrast ratio of top sites labels is too low[/+] on Sep 16, 2020
  7. brampitoyo commented on Sep 16, 2020

    @brampitoyo

    Sorry. I made a mistake here. I will fix this issue on #15123. Let’s close this one in favour of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs:triageIssue needs triage🐞 bugCrashes, Something isn't working, ..

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions