This repository was archived by the owner on Feb 20, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 20, 2023. It is now read-only.
Add a setting to toggle the display of frequently visited top sites #14119
Description
This issue is to add a toggle-able setting to toggle whether frequently visited top sites are displayed. The below mock is just an example - the exact wording and placement are still tbd by UX.
┆Issue is synchronized with this Jira Task
Activity
For mozilla-mobile#14119 - Add a setting to toggle the display of fre…
vesta0 commentedon Aug 24, 2020
I think it should be under the "customize" setting. The string looks good to me.
cc @betsymi and @topotropic
gabrielluong commentedon Aug 25, 2020
Not sure, how it should look under "customize" setting since those have been radio toggles instead of a switch toggle that you see in the screenshot.
vesta0 commentedon Aug 25, 2020
Good point. Let's see what @betsymi says. I recommend keeping it as simple as possible for now and re-evaluating later.
Thanks for working so hard to get this in @gabrielluong :)
topotropic commentedon Aug 25, 2020
Customize might be a better place for this option; cc @betsymi for feedback
betsymi commentedon Aug 25, 2020
+1 to customize placement. This will also give us flexibility to make adjustments in the future if we open up the opportunity for users to customize collections in some way.
Do I understand correctly that toggling this feature off would remove all top sites from Home, including those you may have pinned yourself? If that is true, I recommend
Show top sites. I removed "auto-generated" to cover both cases and to shorten the string.Question about behavior: If I were to toggle this off, then toggle it back on, do the top sites that were previously there re-appear?
gabrielluong commentedon Aug 25, 2020
Show top sitesandAuto-generated top sitesaren't quite correct. We still want to show user pinned top sites. We're adding a feature that is already available in Fennec and Desktop to show frequently visited sites in Top Sites on top of user pinned top sites. The toggle itself should disabling showing the frequently visited sites. These sites are based on your user visited site history. Toggling on/off will toggle the display of only frequently visited sites. My initial recommendation isShow Top Frequently Visited Sites.betsymi commentedon Aug 25, 2020
Thanks for that additional context and clarification. I now understand toggling this off would hide frequently visited sites only, while allowing your manually add top sites to persist.
For continuity's sake across platforms, I'm going to recommend language that we use on desktop (In desktop preferences we describe Top sites as the sites you visit most as well as in SUMO )
Show most visited sitesFor mozilla-mobile#14119 - Add a setting to toggle the display of fre…
3 remaining items
For mozilla-mobile#14119 - Add a setting to toggle the display of fre…
For mozilla-mobile#14119 - Add a setting to toggle the display of fre…
For mozilla-mobile#14119 - Add a setting to toggle the display of fre…
For #14119 - Add a setting to toggle the display of frequently visite…
LaurentiuApahideanSV commentedon Sep 2, 2020
I tested the issue on Nightly 9/2 and 81.1.0-beta.1. The option is present in Nightly but not in Beta, even though patch notes for the Beta build should contain this fix.
Devices used:
gabrielluong commentedon Sep 2, 2020
@LaurentiuApahideanSV This setting is currently feature flagged for nightly and debug builds only for now. We haven't officially let the feature of showing frequently visited sites ride enabled ON by default. We will still need to address some of the known bugs before we want to show frequently visited sites. I think we can say this verified for the time being.
liuche commentedon Sep 3, 2020
We'll remove the flag so it can get to beta testers sooner, so sending another build soon to be tested.
LaurentiuApahideanSV commentedon Sep 3, 2020
Verified as fixed on Firefox Preview Beta 81.1.0-beta.2 (Build #2015761657).
Devices used:
For mozilla-mobile#14119 - Add a setting to toggle the display of fre…