Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Add ability to disable individual autocomplete providers #5745

Closed

Description

Fenix does have option to disable autocomplete, but it doesn't work for "default URL list", which still autocomplete random URLs, not sure if this is bug or simply missing feature, correct me if wrong.

Little annoyance.

┆Issue is synchronized with this Jira Task

Activity

  1. ghost added on Oct 2, 2019
  2. cadeyrn commented on Oct 3, 2019

    @cadeyrn
    Contributor

    not sure if this is bug or simply missing feature

    It's a missing feature, not a bug. The old Firefox aka Fennec also doesn't have an option to disable this feature.

    I vote for adding such an option because how to disable this feature is a question that keeps coming up in Firefox support. It was already the case for Fennec and there were already requests for Fenix, too.

  3. ealitten commented on Nov 1, 2019

    @ealitten

    The ability to turn this off does appear in Firefox Focus, which I thought fenix was at least partially based on: https://support.mozilla.org/en-US/kb/autocomplete-settings-firefox-focus-address-bar

    I do hope this feature is added, since I find it quite annoying for my urls to autocomplete to sites I have never and will never visit (the list seems very US-focused which means it's almost never of interest to me)

  4. cadeyrn commented on Nov 1, 2019

    @cadeyrn
    Contributor

    The ability to turn this off does appear in Firefox Focus, which I thought fenix was at least partially based on

    Fenix is not based on Firefox Focus. Both browsers use Android Components and GeckoView but are completely independently.

  5. ealitten commented on Nov 1, 2019

    @ealitten

    Ah OK, I stand corrected - the common use of Android Components and GeckoView must be where I got that idea from

  6. omaralsharif commented on Mar 15, 2020

    @omaralsharif

    I really think this issue should be addressed, as it may lead to a first impression that causes the user to question the browser's privacy claim.

    Having the browser autocomplete to 'a list of popular sites' implies that the browser is collecting browsing data from somewhere. If the autocomplete is accurate, it may even imply that it has data on the user in advance.

    This may conflict with one of browser's main claims of "privacy"

  7. christianfl commented on Apr 24, 2020

    @christianfl

    Fennec has an about:config flag, better to add the setting to Firefox options since about:config may not be available in the stable branch.

    This flag in Fennec disables all search autocompletion, not only the default (sponsored) ones. I couldn't even find those URLs in the source code with grep, where are they stored?

  8. cadeyrn commented on Apr 24, 2020

    @cadeyrn
    Contributor

    not only the default (sponsored) ones

    These are no sponsored URLs but the most popular websites according to one of the Alexa top lists.

    I couldn't even find those URLs in the source code with grep, where are they stored?

    https://github.com/mozilla-mobile/android-components/tree/master/components/browser/domains/src/main/assets/domains

  9. omaralsharif commented on Jun 6, 2020

    @omaralsharif

    The flags in about:config are either bugged or completely different at this point in time, as the current urlbar flags have no effect.

    I'd love bring given the option to only autocomplete from history or bookmarks (rather than the Alexa top site list), but I'd definitely be satisfied with disabling autocomplete entirely

  10. cadeyrn commented on Jun 6, 2020

    @cadeyrn
    Contributor

    The flags in about:config are either bugged or completely different at this point in time, as the current urlbar flags have no effect.

    There was never a about:config option for that, neither in Fennec nor in Fenix.

  11. crisalis2 commented on Jun 16, 2020

    @crisalis2

    The flags in about:config are either bugged or completely different at this point in time, as the current urlbar flags have no effect.

    There was never a about:config option for that, neither in Fennec nor in Fenix.

    Wrong. If you set browser.urlbar.autocomplete.enabled to false in Fennec, the Alexa top sites thing gets removed: for example, if you write "a" in the urlbar, no "amazon.com" suggestion comes up.
    Now, in Fenix, setting browser.urlbar.autocomplete.enabled to false makes no difference. The "amazon.com" suggestion (which not only is unremovable spam, but also not even the relevant Amazon URL for my country) and all the other ones are still there.
    This single problem makes Fenix worse than Fennec for me, and I'm sure I'm not alone.

    There are options in about:config, like browser.urlbar.autocomplete.enabled, that simply don't work in Fenix. @omaralsharif is correct. Another example is browser.urlbar.trimURL: in Fennec, if you set it to false, it makes the urlbar show the "http(s)://" part. In Fenix, the "http(s)://" part doesn't come back no matter what.

    Please, pay some attention to this issue. There are working features in Fennec that don't work in Fenix. Having options is good. And we are talking about options that were already there at that.

  12. Crandel commented on Jun 28, 2020

    @Crandel
  13. 35 remaining items

  14. added a commit that references this issue on Sep 11, 2020
  15. boek commented on Sep 11, 2020

    @boek
    Contributor

    Hey all, thank you for this feedback!

    Let me see what we can do about allowing more fine tuning of the controls here!

  16. removed
    needs:UX-investigationIssues where UX needs to define or scope a solution or determine feasibility
    needs:acNeeds Android Component Work
    on Sep 11, 2020
  17. changed the title [-]Option to disable default / custom URL list autocomplete[/-] [+]Add ability to disable separate autocomplete providers[/+] on Sep 11, 2020
  18. changed the title [-]Add ability to disable separate autocomplete providers[/-] [+]Add ability to disable individual autocomplete providers[/+] on Sep 11, 2020
  19. added
    needs:UX-investigationIssues where UX needs to define or scope a solution or determine feasibility
    and removed on Sep 11, 2020
  20. liuche commented on Sep 12, 2020

    @liuche
    Contributor

    @sv-ohorvath to clarify, the feature you verified is in fact "turn off all autocomplete" - thank you for verifying! That fix is working as intended.

    We have then re-purposed (and re-named this bug) to handle more specific autocomplete controls (which may be history, top sites, bookmarks, etc) with UX feedback.

  21. added 3 commits that reference this issue on Sep 13, 2020
  22. cpeterso commented on Dec 27, 2022

    @cpeterso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions