[codrut-topliceanu]

Fixes #13765

Pull Request checklist

• Tests: This PR doesn't include any tests as it is only a minor change.
• Screenshots: This PR includes screenshots.
• Accessibility: The code in this PR follows accessibility best practices.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

I followed the specs in #13765 as best as I could, however the distance between columns needs to be variable(X value in the screenshot) otherwise wider devices will only have top sites on the left side of their screens. I have also added 12dp spacing between rows as it felt appropriate. You can find further screenshots from a Pixel 3XL (for both orientations) below, please let me know if any more changes are required.

[codecov-commenter]

Codecov Report

Merging #14278 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #14278      +/-   ##
============================================
- Coverage     29.61%   29.57%   -0.05%     
+ Complexity     1134     1132       -2     
============================================
  Files           440      440              
  Lines         17653    17689      +36     
  Branches       2295     2299       +4     
============================================
+ Hits           5228     5231       +3     
- Misses        12043    12075      +32     
- Partials        382      383       +1     

Impacted Files	Coverage Δ	Complexity Δ
...a/org/mozilla/gecko/search/SearchWidgetProvider.kt	24.00% <0.00%> (-9.34%)	1.00% <0.00%> (ø%)
...in/java/org/mozilla/fenix/settings/SupportUtils.kt	70.00% <0.00%> (-4.00%)	11.00% <0.00%> (-2.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f763a50...1e7e118. Read the comment docs.

[apbitner]

Looking much better! For landscape and higher resolutions, I do think we should set a max width for the container of the top sites. I propose a max width between top sites of 64px, meaning the max width for the container would be 448px.

[liuche]

Hi @codrut-topliceanu do we think this could be done in time to make the "late" cut on Tuesday? thank you!

[codrut-topliceanu]

I've made the requested changes. @apbitner could you please take a look and tell me if they are ok? (I've also tested this on ldpi and xhdpi emulators/devices and everything seems in order)

[Mugurell]

Looks good, thanks!

[lobontiumira]

Hi all,
I've noticed on the latest Beta 81.1.0-beta.1, and on 9/2 Nightly, on the Samsung Galaxy Tab S6 (Android 9), and on Samsung Galaxy Tab S3 (Android 8) that the default 3 top sites are not centralized. Is this expected?
Thanks,

[Mugurell]

They were already aligned to the left.
This patch changed nothing in this regard.